Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org ā†’
Created on 28 March 2023, over 1 year ago
Updated 4 August 2024, 5 months ago

Problem/Motivation

Getting following error/warnings.

FILE: /var/www/html/modules/contrib/language_selection_page/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------
12 | WARNING | Line exceeds 80 characters; contains 91 characters
16 | WARNING | Line exceeds 80 characters; contains 88 characters
17 | WARNING | Line exceeds 80 characters; contains 83 characters
22 | WARNING | Line exceeds 80 characters; contains 95 characters
24 | WARNING | Line exceeds 80 characters; contains 93 characters
25 | WARNING | Line exceeds 80 characters; contains 85 characters
30 | WARNING | Line exceeds 80 characters; contains 96 characters
31 | WARNING | Line exceeds 80 characters; contains 88 characters
34 | WARNING | Line exceeds 80 characters; contains 95 characters
36 | WARNING | Line exceeds 80 characters; contains 85 characters
40 | WARNING | Line exceeds 80 characters; contains 84 characters
41 | WARNING | Line exceeds 80 characters; contains 204 characters
----------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/language_selection_page/src/Plugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionType.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
111 | WARNING | [ ] #options values usually have to run through t() for translation
112 | WARNING | [ ] #options values usually have to run through t() for translation
113 | WARNING | [ ] #options values usually have to run through t() for translation
167 | ERROR | [x] list(...) is forbidden, use [...] instead.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/language_selection_page/src/Plugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionTitle.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
32 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/language_selection_page/src/Plugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionPath.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
136 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
--------------------------------------------------------------------------------------------------------------------------------------------

Time: 5.17 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/language_selection_page/

Proposed resolution

Above error/warnings need to be fixed.

šŸ“Œ Task
Status

Needs work

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India samit.310@gmail.com

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

  • Needs reroll

    The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @samit.310@gmail.com
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India samit.310@gmail.com

    Above errors/warnings has been fixed.

    README.txt file issues are not covered here as Replace README.txt with README.md šŸ“Œ Replace README.txt with README.md RTBC issue is there.

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India hardikpandya

    Tested by applying the patch and can confirm there are no more phpcs issues reported. RTBC +1

  • Status changed to Needs work 5 months ago
  • Comment 5 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi

    I applied patch #2 and I can see these PHPCS issues:

    āžœ  language_selection_page git:(8.x-2.12) curl https://www.drupal.org/files/issues/2023-03-28/3350776-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3059  100  3059    0     0   6526      0 --:--:-- --:--:-- --:--:--  6723
patching file 'src/Plugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionPath.php'
patching file 'src/Plugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionTitle.php'
patching file 'src/Plugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionType.php'
āžœ  language_selection_page git:(8.x-2.12) āœ— ..
āžœ  contrib git:(2.1.x) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml language_selection_page

FILE: ...web/modules/contrib/language_selection_page/language_selection_page.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ge/tests/modules/src/Plugin/LanguageNegotiation/TestLanguageNegotiator.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...selection_page/tests/src/Functional/LanguageSelectionPageConditionTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...eb/modules/contrib/language_selection_page/language_selection_page.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ubing-subing/provus/web/modules/contrib/language_selection_page/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
 12 | WARNING | Line exceeds 80 characters; contains 91 characters
 16 | WARNING | Line exceeds 80 characters; contains 88 characters
 17 | WARNING | Line exceeds 80 characters; contains 83 characters
 22 | WARNING | Line exceeds 80 characters; contains 95 characters
 24 | WARNING | Line exceeds 80 characters; contains 93 characters
 25 | WARNING | Line exceeds 80 characters; contains 85 characters
 30 | WARNING | Line exceeds 80 characters; contains 96 characters
 31 | WARNING | Line exceeds 80 characters; contains 88 characters
 34 | WARNING | Line exceeds 80 characters; contains 95 characters
 36 | WARNING | Line exceeds 80 characters; contains 85 characters
 40 | WARNING | Line exceeds 80 characters; contains 84 characters
 41 | WARNING | Line exceeds 80 characters; contains 204 characters
--------------------------------------------------------------------------------


FILE: .../language_selection_page/src/Form/NegotiationLanguageSelectionPageForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ib/language_selection_page/src/LanguageSelectionPageConditionInterface.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...trib/language_selection_page/src/LanguageSelectionPageConditionManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...rc/Plugin/LanguageNegotiation/LanguageNegotiationLanguageSelectionPage.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionType.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../LanguageSelectionPageCondition/LanguageSelectionPageConditionIndexPhp.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...eSelectionPageCondition/LanguageSelectionPageConditionBlacklistedPaths.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...uageSelectionPageCondition/LanguageSelectionPageConditionIgnoreNeutral.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...nguageSelectionPageCondition/LanguageSelectionPageConditionPathIsValid.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...uageSelectionPageCondition/LanguageSelectionPageConditionMethodIsValid.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...gin/LanguageSelectionPageCondition/LanguageSelectionPageConditionTitle.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionPath.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...n/LanguageSelectionPageCondition/LanguageSelectionPageConditionPHPSapi.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ageSelectionPageCondition/LanguageSelectionPageConditionXMLHTTPRequest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...eSelectionPageCondition/LanguageSelectionPageConditionLanguagePrefixes.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ib/language_selection_page/src/Plugin/Block/LanguageSelectionPageBlock.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../language_selection_page/src/Annotation/LanguageSelectionPageCondition.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/contrib/language_selection_page/src/Controller/LegacyDrupal7Redirect.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...language_selection_page/src/Controller/LanguageSelectionPageController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...contrib/language_selection_page/src/LanguageSelectionPageConditionBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...nguage_selection_page/src/Routing/LanguageSelectionPageRouteController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...age_selection_page/src/EventSubscriber/LanguageSelectionPageSubscriber.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Config\ConfigFactoryInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 960ms; Memory: 12MB

āžœ  contrib git:(2.1.x) āœ—
  • Comment 5 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Let's use a merge request, now that patches are no longer tested.

  • Merge request !9Issue #3350776: Fix the issues reported by phpcs ā†’ (Open) created by apaderno
  • Pipeline finished with Failed
    5 months ago
    Total: 50s
    #243702
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024