- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:51am 24 March 2023 - First commit to issue fork.
- @dineshkumarbollu opened merge request.
- Status changed to RTBC
almost 2 years ago 7:01am 24 March 2023 - 🇮🇳India dineshkumarbollu
Hi
The patch is applied zero phpcs errors in my local.
Then I created MR for this patch.Thanks.
- Status changed to Needs work
almost 2 years ago 5:33am 30 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Removing credit for the MR when there was already a patch.
@samit.310@gmail.com, whilst I appreciate coding standards patches, my policy is not to give credit to contributors who already have credit for coding standards patches. Coding standards patches are great for folks finding their feet with the mechanics of contribution, but more experienced developers can help in other ways. Please refer to tip 2 on https://www.previousnext.com.au/blog/5-simple-tips-increase-your-drupal-... for more information. As I can see from your profile that you have a number of phpcs credits already, I've decided to remove your credit in this instance.
+++ b/tests/src/Kernel/ChainedFieldBuildTest.php @@ -55,7 +60,7 @@ class ChainedFieldBuildTest extends EntityKernelTestBase { - $user_with_no_value = $this->createUser(); + $this->createUser();
Can we replace this with a comment - e.g.
'Create a user with no value for test_field' to explain why we need it?