- Issue created by @kim.pepper
- Assigned to akshaydalvi212
- ๐ฎ๐ณIndia akshaydalvi212
I will work on updating the service.yml for creating new service decorator.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:32pm 24 March 2023 - ๐ฎ๐ณIndia akshaydalvi212
I tried to create the service decorator and replace it in the service.yml file.
Providing the #3 patch file.
kindly review. - ๐ฉ๐ชGermany Anybody Porta Westfalica
I think this might also lower the risk for bugs and incompatibilities in the future?
- Status changed to Needs work
about 1 year ago 10:47am 30 October 2023 - ๐ฎ๐นItaly lussoluca Italy
The actual patch fails with this error:
Fatal error: Uncaught TypeError: Drupal\Core\Config\ConfigFactory::__construct(): Argument #2 ($event_dispatcher) must be of type Symfony\Contracts\EventDispatcher\EventDispatcherInterface, Drupal\tracer\Controller\TraceableControllerResolver given, called in /var/www/html/web/core/lib/Drupal/Component/DependencyInje ction/Container.php on line 259 and defined in /var/www/html/web/core/lib/Drupal/Core/Config/ConfigFactory.php:72
- Status changed to Needs review
7 months ago 4:18pm 8 May 2024 - ๐ฎ๐ฉIndonesia el7cosmos ๐ฎ๐ฉ GMT+7
I created an MR to decorate the event dispatcher service instead, but this only works in 10.3.
If we want this on 10.2 also, we can create a compiler pass similar to https://git.drupalcode.org/project/drupal/-/commit/6e733866fe414d0521be3... that only works for <10.3 (eg using deprecation helper)
- Status changed to Postponed
6 months ago 8:45pm 20 May 2024 - ๐ฎ๐นItaly lussoluca Italy
Probably, decorating the event_subscriber is no longer possible until ๐ Replace ContainerAwareEventDispatcher with Symfony EventDispatcher Fixed lands on Drupal 11 (required changes have been reverted in ๐ Add BC layer for contrib modules using ContainerAwareEventDispatcher as a typehint (BC fix for #2909185) Fixed )