- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:32pm 8 March 2023 - ๐ฎ๐ณIndia aakansha tyagi
I have fixed the above coding standards issues. Please review it.
Hi, patch #5 applied cleanly, fixing most of the errors. One error still needs to be fixed.
- ๐ฎ๐ณIndia Jasjeet Kaur Brar
Jasjeet Kaur Brar โ made their first commit to this issueโs fork.
- Status changed to Needs work
4 months ago 6:02am 9 July 2024 - ๐ฎ๐ณIndia dev2.addweb
nilesh.addweb โ made their first commit to this issueโs fork.
- Status changed to Needs review
4 months ago 6:12am 17 July 2024 - ๐ฎ๐ณIndia dev2.addweb
Hi,
I have fixed remaining phpcs issues and fixed conflict from upstream. please review it. - Status changed to RTBC
4 months ago 6:38am 17 July 2024 - ๐ฎ๐ณIndia riddhi.addweb
The mentioned phpcs issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.
- Status changed to Fixed
3 months ago 1:32am 24 August 2024 - ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
I'm giving credit on this issue but not taking a lot of the changes. Maybe someone can explain while i should care someday but until then i am not making perfectly readable 89 character lines into three less readable ones because phpcs tells me too.
A fair number of the warnings appear to be at odds with Drupal's coding standards (not allowing inline doc block comments that start with
/**
??)For modules i maintain please check with me before undertaking these sorts of patches, please.
(The merge request also commented out a couple variables which is absolutely not OK in a formatting patch!)
Automatically closed - issue fixed for 2 weeks with no activity.