- Issue created by @cosmicdreams
- πΊπΈUnited States brianperry
Added `Scroll position is lost when refreshing the preview` as a nice to have.
I'm also thinking that `Provide a button to open preview in new page` should be a release blocker. And maybe `Allow user to show preview pane by default` as well. Thoughts?
- πΊπΈUnited States brianperry
I also think β¨ Toggle Preview Should Refresh Preview Fixed should be a release blocker.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
For 1.0.x, I'm thinking of the question:
What are all the things this needs to have in order to start being useful?
The initial release isn't going to be our last release. So we just need to put a version out that we'll want to support until the next version comes out. That said I can make an argument for each of the release blockers:
β¨ [meta] Address accessibility concerns Active
Accessibility is an important gate to get through for Drupal work. And, speaking for myself here, I don't make a lot of modules. It's cool to learn what is all needed in order to properly produce work that is accessible.π Add a grabber to the left border of the dialog Postponed
Is really a nice to have, if we don't have this feature the same page preview doesn't break.β¨ Move Preview controls to edit page Fixed
I think this is on the fence of being a release blocker. This is an important feature to consider as changing this in the future might mean breaking backwards compatibility.π Add Tests Fixed
Really should be a release blocker, but we could skate on manual testing for a while. I'm struggling to figure this out and the struggle is kind of fun right now.π On by default, make off-by-default an opt-in setting Closed: duplicate
Really it's a nice to have. We can add this later without breaking backwards compatibility⨠Scroll position is lost when refreshing the preview Fixed
Likewise, saving the scroll position could be added without breaking backwards compatibility. If not, yes, it should be a release blocker.π Provide a button to open preview in new page Active
I DO however think that adding a preview button is a release blocker. If we don't provide one then we've broken backwards compatibility. Users can currently click on preview and see a full preview. After the install our module they can't.β¨ Toggle Preview Should Refresh Preview Fixed
This sounds like the stereotypical nice to have. It extends a button that we've added with additional behavior. Yes, I think it's likely that we'll need to have the link to a button but I don't think it will actually "break" anything if we do that. - πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Very close to 1.0.x @shaal, let's discuss β¨ [meta] Address accessibility concerns Active
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
β¨ Toggle Preview Should Refresh Preview Fixed has a fix. Once in we have 1 more blocker to complete then we can focus on phase 2.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Next Steps
- Update animated gif + demo
- Put out master plan on the module project page
- Status changed to Needs work
over 1 year ago 11:02pm 29 March 2023 - πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
V1 is at alpha. We can tweak it some more. The majority of our focus is on Phase 2
We haven't heard much from the community about whether they're excited about V1 and need it to be polished more. But if they do we can put some effort into here.
I for one, am very excited about what is coming in Phase 2. If it appears that we have low uptake on v1 we could just squash it and have 2.0.x be our sole release.
- π³π±Netherlands Martijn de Wit π³π± The Netherlands
Saw a demo via Twitter. It looks very promising all. I think it up to the real editors if they gone use / love this new module.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Thank you! A new demo video may come later this week. We'll be able to share the recent wins that have landed. Keep following the progress here
- Status changed to Fixed
over 1 year ago 1:03am 9 June 2023 - πΊπΈUnited States brianperry
Marking as fixed since we're well past 1.0 at this point.
Automatically closed - issue fixed for 2 weeks with no activity.