- Issue created by @lauriii
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Perhaps we could use localStorage to store the scroll position?
- First commit to issue fork.
- @omkar-pd opened merge request.
- Status changed to Needs review
over 1 year ago 1:06pm 23 March 2023 - 🇮🇳India omkar-pd
Used localStorage to remember the last scroll position and scroll back to the same position refresh.
Please review and suggest if we can use a better approach. - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
@omkar-pd feedback added. This is moving in the right direction.
- Status changed to Needs work
over 1 year ago 6:04pm 23 March 2023 - Status changed to Needs review
over 1 year ago 2:26pm 24 March 2023 - 🇮🇳India omkar-pd
@cosmicdreams
I have addressed the given feedback. Please have a look. - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
And in other work, we could hide view mode behind a permissions
- Status changed to Needs work
over 1 year ago 10:47pm 26 March 2023 - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
back to needs work. Great progress, please keep going.
- Status changed to Needs review
over 1 year ago 3:14pm 27 March 2023 - 🇮🇳India omkar-pd
Made all the changes. Changing status back to Needs review.
- Assigned to brianperry
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
looking good, back to Brian for review
- First commit to issue fork.
- 🇨🇦Canada mandclu
Updated based on most recent commits to the 2.0.x branch. Also, to update the target scroll position before refresh.
- 🇨🇦Canada mandclu
I updated the MR to merge in the latest commits from the 2.0.x branch, and to have the scrollPosition state variable updated just before a refresh. I updated this issue to target the 2.0.x branch but it won't let me update the target for the MR.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Good call on updating the target for the MR. I'll jump in and review.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
MR21 still appears to target 1.0.x. That seems to no longer be the intention for this work's inclusion. I'll see if I can switch it to 2.0.x but we might be at a point where we have to close the MR and open a new one.
- First commit to issue fork.
- 🇺🇸United States brianperry
Pushed up a fix to reset the scroll position when changing view modes, and also made the code cleanup tweaks I mentioned.
Needs a last look from someone else, but good to go from my perspective.
- Status changed to RTBC
over 1 year ago 5:39pm 8 April 2023 - 🇨🇦Canada mandclu
I made one additional (very minor) tweak, so maybe I shouldn't be the one to RTBC this, but this is looking really solid to me.
-
cosmicdreams →
committed 3d5342e2 on 2.0.x authored by
omkar-pd →
Issue #3345266 by omkar-pd, mandclu, brianperry: Scroll position is lost...
-
cosmicdreams →
committed 3d5342e2 on 2.0.x authored by
omkar-pd →
- Status changed to Fixed
over 1 year ago 9:32pm 8 April 2023 - Status changed to Fixed
over 1 year ago 1:09am 26 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.