- Issue created by @cosmicdreams
- πΊπΈUnited States brianperry
should we be displaying the version of the content that the ADMINISTRATOR sees, or should we be displaying the content that AUTHENTICATED users see?
Perhaps it is somewhere in-between? Showing what the current authenticated user would see, but with UI that isn't relevant to this task (previewing content) disabled.
We're already taking some conceptually similar steps when embedding the preview. In same_page_preview_preprocess_html we remove the admin toolbar. Seems reasonable to me that we might also disable things like quickedit.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Yes, I see a path there. We could pick and choose pieces to manually remove. The list of things to possibly tweak / exclude is not infinite. But a more complete solution would be to show a preview as non-admin sees it.
Since proposing that, I came to think of all the edge cases that might cause.
- Previewing a secure page
- Pages that have different contexts applied (analytics driven displays, language
- lots of stuff I'm probably not thinking of
I think the purpose of the same page preview is to not overwhelm the user with choices. Just the preview please. The full preview could the place to get all specific with choices / personalization / formats. There certainly would be space for all that.
With that in mind, I'm all for doing what we have to do to get this happy path handled.
- @cosmicdreams opened merge request.
- @cosmicdreams opened merge request.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
I have a MR that removes contextual links from the preview
- Status changed to Needs review
almost 2 years ago 8:31pm 14 March 2023 - Status changed to RTBC
almost 2 years ago 9:47pm 14 March 2023 - πΊπΈUnited States brianperry
This looks good from my perspective.
-
cosmicdreams β
committed e57d53aa on 1.0.x
Issue #3347602 by cosmicdreams, brianperry: Remove additional...
-
cosmicdreams β
committed e57d53aa on 1.0.x
- Status changed to Fixed
almost 2 years ago 10:01pm 14 March 2023 - Status changed to Fixed
almost 2 years ago 10:49pm 17 March 2023