Photoswipe responsive formatter shows no image, if configured to hide any thumbnail except the first one

this one-liner fixes the problem for me

LGTM! @Grevil could you please check this and add a test which fails for now and works after the fix?
If anything is unclear, contact me.

@agoradesign to speed things up, you can also add the test please, otherwise this may take some month to be fixed and committed. Very busy times here :)

I'm so sorry. Similar situation here...

If I'd had both more time and knowledge about the internals of photoswipe module, I'd first investigate, why it's even necessary to have the style_name set in the responsive formatter. I believe it's a side effect of re-using as much as possible from the normal image formatter.

Hello, it actually was not working. I've implemented a test that checks if the hide option work. Above I attached a patch with only the test in it, it should fail on the current 3.x branch.

Woops, attached wrong patch. Here is the appropriate one.

The last submitted patch, 9: 3343669-photoswipe-responsive-formatter--only-test.patch, failed testing. View results →

As you can see it failed.

Do we really need all this config installed inside the test module? Can we not simply create most stuff programmatically?

Well, the config idea is not bad, on the other side it has the risk of being different from the real world config... I'm not sure which of both paths to go... pro's / con's?

What's the 4.x and 5.x status here?

Let's also check if other responsive image styles work as expected, I guess after that, we can merge this.

Ok, I added a test to check the hidden node_style_first option. I think the last test I mentioned in #15 is out of scope here.

Great work @dinazaur! Let's get this merged!

Thanks, this really looks great, heavy work!
I left a comment, as that removal looks dangerous to me and should be safety-checked by an additonal test, if we don't have one yet. Could you take a look please @dinazaur? Perhaps I'm wrong.

Re.

Thanks @Grevil for the clarification. RTBC then. Thanks!

I do not have any permission on the current "3343669-photoswipe-responsive-formatter" branch anymore after this was set to fix. I originally created a new MR here: https://git.drupalcode.org/issue/photoswipe-3343669/-/merge_requests/1, but now this MR is also broken, no idea what's happening, the new Gitlab UI is horrible and doesn't seem to properly work with the Drupal commit hooks.

I'll try to simply cherry-pick the commit, which probably won't work.

Ok, needed to cherry-pick it locally, all committed now, thanks all!

@Grevil: Tests in 5.x are now failing, I think it's probably due to this commit. So I'm reopening to take a look at 5.x again.

Will be fixed in 🐛 Photoswipe responsive formatter shows no image, if configured to hide any thumbnail except the first one Fixed . Sorry, should've straight up create a second branch. I usually do that through the UI, which wasn't possible through the new GitLab UI. Please correct me if I am wrong, but I can't create a new branch here: https://git.drupalcode.org/issue/photoswipe-3343669/-/branches.

@Grevil #30 references THIS issue (self). Where will it be fixed?

Ah: 📌 Fix currently failing schema errors in tests. Fixed

Automatically closed - issue fixed for 2 weeks with no activity.