Fix currently failing schema errors in tests.

Testing Drupal\Tests\photoswipe\FunctionalJavascript\ResponsiveImageTest ER 2 / 2 (100%)E Time: 00:09.359, Memory: 4.00 MB There were 2 errors: 1) Drupal\Tests\photoswipe\FunctionalJavascript\ResponsiveImageTest::testPhotoswipeResponsiveHideOption Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for core.entity_view_display.node.node.default with the following errors: core.entity_view_display.node.node.default:content.field_image.settings.photoswipe_node_style_first missing schema, core.entity_view_display.node.node.default:content.field_image.settings.photoswipe_node_style missing schema, core.entity_view_display.node.node.default:content.field_image.settings.photoswipe_caption missing schema, core.entity_view_display.node.node.default:content.field_image.settings.photoswipe_caption_custom missing schema, core.entity_view_display.node.node.default:content.field_responsive_image.settings.photoswipe_node_style_first missing schema, core.entity_view_display.node.node.default:content.field_responsive_image.settings.photoswipe_node_style missing schema, core.entity_view_display.node.node.default:content.field_responsive_image.settings.photoswipe_caption missing schema, core.entity_view_display.node.node.default:content.field_responsive_image.settings.photoswipe_caption_custom missing schema /var/www/html/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:94 /var/www/html/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111 /var/www/html/core/lib/Drupal/Core/Config/Config.php:229 /var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:274 /var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486 /var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:253 /var/www/html/core/lib/Drupal/Core/Entity/EntityBase.php:339 /var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:608 /var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:388 /var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:148 /var/www/html/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75 /var/www/html/core/lib/Drupal/Core/Extension/ModuleInstaller.php:319 /var/www/html/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83 /var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:474 /var/www/html/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:77 /var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:543 /var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:362 /var/www/html/modules/contrib/photoswipe/tests/src/FunctionalJavascript/ResponsiveImageTest.php:51 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 2) Drupal\Tests\photoswipe\FunctionalJavascript\ResponsiveImageTest::testPhotoswipeResponsiveHideFirstOption Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for core.entity_view_display.node.node.default with the following errors: core.entity_view_display.node.node.default:content.field_image.settings.photoswipe_node_style_first missing schema, core.entity_view_display.node.node.default:content.field_image.settings.photoswipe_node_style missing schema, core.entity_view_display.node.node.default:content.field_image.settings.photoswipe_caption missing schema, core.entity_view_display.node.node.default:content.field_image.settings.photoswipe_caption_custom missing schema, core.entity_view_display.node.node.default:content.field_responsive_image.settings.photoswipe_node_style_first missing schema, core.entity_view_display.node.node.default:content.field_responsive_image.settings.photoswipe_node_style missing schema, core.entity_view_display.node.node.default:content.field_responsive_image.settings.photoswipe_caption missing schema, core.entity_view_display.node.node.default:content.field_responsive_image.settings.photoswipe_caption_custom missing schema /var/www/html/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:94 /var/www/html/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111 /var/www/html/core/lib/Drupal/Core/Config/Config.php:229 /var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:274 /var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486 /var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:253 /var/www/html/core/lib/Drupal/Core/Entity/EntityBase.php:339 /var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:608 /var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:388 /var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:148 /var/www/html/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75 /var/www/html/core/lib/Drupal/Core/Extension/ModuleInstaller.php:319 /var/www/html/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83 /var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:474 /var/www/html/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:77 /var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:543 /var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:362 /var/www/html/modules/contrib/photoswipe/tests/src/FunctionalJavascript/ResponsiveImageTest.php:51 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 -- There was 1 risky test: 1) Drupal\Tests\photoswipe\FunctionalJavascript\ResponsiveImageTest::testPhotoswipeResponsiveHideOption This test did not perform any assertions /var/www/html/core/tests/Drupal/Tests/Listeners/DrupalListener.php:66 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:452 /var/www/html/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:377 /var/www/html/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:183 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673 /var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:661 /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:144 /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:97 ERRORS! Tests: 2, Assertions: 0, Errors: 2, Risky: 1.

Comments & Activities

Issue created by @Grevil
Comment over 1 year ago →
🇩🇪Germany Grevil
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
15 pass, 2 fail
@grevil opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
17 pass
Status changed to Needs review over 1 year ago9:38am 7 August 2023
Comment over 1 year ago →
🇩🇪Germany Grevil
I decided against creating the node bundle, field storage, field config, etc. via config, as I already got into trouble with that approach using the configs from 4.x inside 5.x tests. Instead, we just create everything programmatically inside the tests. I'd say this approach is more "future-proof" and we don't need to have the test setup module anymore. Please review!
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
Thanks @Grevil I agree that might make sense. Left a comment on another change.
Comment over 1 year ago →
🇩🇪Germany Grevil
node_style_first was introduced from the recent cherry-pick.
Status changed to RTBC over 1 year ago10:21am 7 August 2023
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
RTBC!
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
17 pass
Comment over 1 year ago →
🇩🇪Germany Grevil
Simply added a comment, since this fails locally for unknown reasons. This shouldn't affect the tests.
Comment over 1 year ago →
System Message

Grevil → committed 299b9998 on 5.x
Issue #3379603: Fix currently failing schema errors in tests.
Comment over 1 year ago →
🇩🇪Germany Grevil
Status changed to Active over 1 year ago10:37am 7 August 2023
Comment over 1 year ago →
🇩🇪Germany Grevil
Status changed to Fixed over 1 year ago10:45am 7 August 2023
Comment over 1 year ago →
🇩🇪Germany Grevil
Nvm, let's not target 4.x anymore, as there isn't any development done.
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix currently failing schema errors in tests.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities