- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:34am 21 February 2023 - Status changed to RTBC
almost 2 years ago 5:00am 21 February 2023 - 🇮🇳India Ranjit1032002
I had Reviewed the patch and it's working as expected mentioned in comment #2
- 🇩🇪Germany Anybody Porta Westfalica
Thank you for this tiny patch with no real world benefit. Please note that this of course won't be credited.
- First commit to issue fork.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
There is no need to create a MR when the patch has been already reviewed and the status changed to Reviewed & tested by the community.
- 🇩🇪Germany Anybody Porta Westfalica
Thank @apaderno! BTW is it okay to not credit people for such minor one-line fixes? Is there any community consent or best practice?
- 🇮🇹Italy apaderno Brescia, 🇮🇹
@Anybody I would not give credit to users who open a MR after the existing patch has been already considered good to go. It seems it is done to get an automatic credit.
I am not sure there is a consensus about that, but I think single maintainers can decide for their own projects. - Status changed to Closed: duplicate
over 1 year ago 3:46pm 22 March 2023