- Issue created by @smustgrave
- First commit to issue fork.
- Merge request !5163Issue #3342489: Add default value for mail_notification in site.system config β (Open) created by _shy
- Status changed to Needs review
over 1 year ago 9:20am 28 October 2023 - πΊπ¦Ukraine _shy Ukraine, Lutsk πΊπ¦
Okay, the tests are passed. Let's see if the changes will fit.
- Status changed to Needs work
over 1 year ago 2:06pm 28 October 2023 - πΊπΈUnited States smustgrave
Thanks! But will need an upgrade path for existing sites.
- Status changed to Needs review
over 1 year ago 9:03pm 30 October 2023 - Status changed to Needs work
over 1 year ago 1:49pm 31 October 2023 - πΊπΈUnited States smustgrave
Thanks! But think in the update we should check if the value is set first. This current update could undo someones setting. So if the value is set we can leave alone, if not set a default.
- Status changed to Needs review
over 1 year ago 2:50pm 31 October 2023 - πΊπ¦Ukraine _shy Ukraine, Lutsk πΊπ¦
Thanks for noticing that. You are totally right @smustgrave, I just missed that thing. That's why I don't like to work at night ;)
Let's check if the tests will pass.
- Status changed to RTBC
over 1 year ago 6:10pm 31 October 2023 - πΊπ¦Ukraine _shy Ukraine, Lutsk πΊπ¦
Hi.
Are more changes needed here? - Status changed to Needs work
over 1 year ago 11:50am 11 November 2023 - Status changed to Needs review
over 1 year ago 12:13pm 11 November 2023 - πΊπ¦Ukraine _shy Ukraine, Lutsk πΊπ¦
Fixed changes after the last comment. All tests are passed.
But, I don't know why it shows so many changes, I just pulled changes from the 11.x branch. - Status changed to RTBC
over 1 year ago 6:07pm 11 November 2023 - πΊπΈUnited States smustgrave
Feedback and moving to system post_update hook seems to have been addressed.
- Status changed to Needs work
over 1 year ago 6:45pm 27 November 2023 - Status changed to Needs review
over 1 year ago 7:34pm 27 November 2023 - Status changed to RTBC
over 1 year ago 10:23pm 27 November 2023 - πΊπΈUnited States smustgrave
Fixed the issue summary to not include TBD and NA for proposed solution.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This was previously missed in #2379683: Fix configuration schema issues in contact (indirectly user and system) modules β and originally introduced in β¨ Allow for custom user registration approval email address Fixed .
I ran into this same problem in π Configuration schema & required keys Fixed .
-
longwave β
committed 4f633dcc on 11.x
Issue #3342489 by _shY, smustgrave, longwave, Wim Leers: Add default...
-
longwave β
committed 4f633dcc on 11.x
- Status changed to Fixed
over 1 year ago 2:07pm 11 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.