The UI selection logic doesn't work correctly

we can do it, just call the same code we use to detect the number of items in during the ajax call, but honestly I don't see a big difference here, if you think it would be better this way I can pass the value, but what I like about the current approach it consistent in every case.
Let me know, I will add it

Just performance, we have an additional AJAX request on page load we can get rid of by adding a single piece of data on the page. This request can be also delayed or fail for some network reasons leaving the end user with unexpected results. Let's do it.

I have added logic to load total count without additional ajax call on load as you asked

The MR doesn't apply to dev when I download the changes and apply to dev using Composer.

As an additional note, I first noticed an issue because clicking a checkbox, then shift+click another box and it selects all the rows in between. However, VBO would only show 2 selected.

There is an extra else here:

https://git.drupalcode.org/project/views_bulk_operations/-/merge_request...

I created a patch file with the MR so far. The MR patch with commit-by-commit changes doesn't apply when using Composer for some reason. The patch with all the cumulative changes does apply.

I tested the changes. It doesn't fix the issue when using shift+click.

Liam Morland → made their first commit to this issue’s fork.

I rebased the merge request. There were merge conflicts and I may not have resolved them correctly. Please review.

Current merge request as a patch.

The shift-click issue is not solved yet unfortunately.. There is an issue for that (or similar) already but I don't like the approach there and the issue is dead for some time.

I'd solve this by checking all item checkboxes state on each change event and send an updated list instead of checking what key combination has been used. We can do it here or in 🐛 Selection not properly updated on multi-page view when using Ctrl+Shift Fixed .

See my next comment there as well because there is possibly a related issue, regardeless of "Always show selection info" option and also with just 1 selection: the "No items selected" is not update in the UI (even if the VBO will execute on selected item) after having updated core from 10.0.9 to 10.1.0.

Should I open another issue instead?

Looking at Drupal 10.1 Release Notes → I found this:

A bug in Drupal's dependency injection container is fixed. The bug could allow certain private services to be accessed by $container->get() depending on code execution order. Custom or contributed module code accessing services in this way would have been fragile before the change, but will now always break. Public services are unaffected.

$container->get() is used extensively in vbo module, maybe check that?
(Unfortunately i'm not a skilled developer so I fear this is all I can help)

Using $container->get() is not bad. Focus on "certain private services". I highly doubt private services are being used that shouldn't be.

Hi all, please check if my solution from #3019720 🐛 Selection not properly updated on multi-page view when using Ctrl+Shift Fixed solves this issue.

Unfortunately that didn't fix the issue for us, the only thing that's changed is the

1) Create a view with bulk operations
2) Check "Always show selection info"
3) The view should return result for one page, for example only one result
4) Open your view
4) Click "Select / deselect all results (all pages, 1 total)", you should see that some entities are selected, for example "Selected 1 item"
5) Uncheck checkboxes in the table
6) You should see now "Selected 0 items"
7) "Apply to selected items" button is active, but it shouldn't, because no entities selected
8) Submit form and you should see warning or error

That last two from the original steps to reproduce are now not working, which is weird, as we have selected two users.

The JS changes do seem to work better but are obviously behind HEAD with the latest changes

Per #20, please check if the issue was fixed by the fixes from 🐛 Selection not properly updated on multi-page view when using Ctrl+Shift Fixed . The fixes are in the latest release.

Just tested: everything seems to work fine now. Thank you.

If it's working, then this can be closed as a duplicate of the other issue.

Yeah, I was just letting the maintainers confirm :)