Selection not properly updated on multi-page view when using Ctrl+Shift

I think I came up with a more simple solution, described it there 🐛 The UI selection logic doesn't work correctly Needs review . In short we don't have to check what key the user pressed but just check state of all checkboxes in the view. It should be a very small change this way.

Actually I just found out that after updating Drupal core from 10.0.9 to 10.1.0 even a normal click selection (not just in a table display but unformatted list as well) is not reflected in the vbo form wrapper (which is now at the bottom of the view only).

Should I open another issue or can this be solved here?

When using core's "Bulk update" views field instead of "Views bulk operations", the selection is updated in the UI instead:

This comment 🐛 The UI selection logic doesn't work correctly Needs review in the related issue might be relevant and the cause of my bug:

Please test this one, it's using my last concept.

The good thing about it is that it should be fool proof in all cases, every change checks the entire page state.
The bad thing is a bit worse performance as we send more data and do more checking in the frontend but it shouldn't be an issue.

Also contains a bit of cleanup.

#22 does fix the shift+click issue.

However, I noticed that the VBO part that says "Selected # items" doesn't update properly after clicking a "select all" checkbox. I have a view with rows grouped by a field, so there are multiple "select all" checkboxes, one for each grouping. Still, I think I could reproduce this with only a single "select all".

Example with 5 rows:

1. Click a checkbox on a row (selected 1 item)
2. Click the "select all" checkbox (selected 1 item, WRONG: should be 5)
3. Click a checkbox on a row to deselect (selected 4 items)
4. Click the same to select it again (selected 5 items)
5. Click the "select all" checkbox (none selected, VBO is hidden)
6. Click the "select all" checkbox (selected 0 items, WRONG: should be 5)

Note that each time I say to click "select all", I'm talking about the select all checkbox on the table, not the one shown by the VBO popup.

Thank you for your testing @solideogloria, I fixed the mentioned issue, please retest, hopefully now all is ok.

This should do the trick. Please retest.

Patch #26 fixes the issues I mentioned in #23.

Thank you.

I just tested the patch as well. I can confirm it works! Thanks, @Graber.

Automatically closed - issue fixed for 2 weeks with no activity.