- Issue created by @Glugmeister
- 🇬🇧United Kingdom Glugmeister
I've had a go at creating a patch for this. Since I'm not sure how to fix postcss processing so that the
box-sizing: border-box
line followingall: initial;
is preserved, I've just moved it to a separate rule targeting all off-canvas html elements. I also removed a superfloustext-shadow: none;
that also followed theall: initial;
. The post css processing convertsall: initial;
into a whole list of individual properties (for browsers that do not support the css 'all' property) and sotext-shadow: none;
gets set anyway in the generated css. - 🇬🇧United Kingdom Glugmeister
Second attempt at a patch. In the first attempt, the additional rule for setting box-sizing: border-box did not have enough specificity.
- Status changed to Needs review
over 1 year ago 10:23am 13 February 2023 - 🇮🇪Ireland markconroy
I'm not sure of the exact issue here. It seems our processor is taking our
box-sizing: border-box
and generatingbox-sizing: content-box; box-sizing: border-box; ... all: initial
The first
content-box
should not be generated because we then immediately placeborder-box
after it. But the finalall: initial
seems very dangerous, as I presume it's overriding everything above it.Adding 2 issues that seem to be related.
- 🇮🇪Ireland markconroy
I think we can fix this by editing /core/.stylelintrc.json and moving
all
to the top of the "order/properties-order" listing. That would mean that "all" comes first to reset what it needs to reset, but then any overrides we need to this, will come after it.I'm honestly not sure if this would be a breaking change and not allowed in Stable in D9 or if this is actually a feature that we need to have in future in our stylelint for D10.
I'll create an MR for this at least, so we can test it.
- @markconroy opened merge request.
- 🇳🇿New Zealand quietone New Zealand
Since stable has been removed from core should this be in the Stable 9 component?
- 🇮🇪Ireland markconroy
@quietone this issue is about stable in d9.5, so I think it can remain here for now. Once 9.5 is no longer supported, I think we can mark this closed: won't fix as it will not be an issue in a contrib theme.
- Status changed to RTBC
over 1 year ago 10:24pm 28 February 2023 - 🇺🇸United States smustgrave
Since technically D9.5 is still supported don't see an issue with merging here. But a follow up with have to be opened for the contrib version.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
This looks good to me and makes sense, all should always come first.
I wonder if we need the same stylelint change in D10+ too?
Tagging for FEFM review.
- last update
over 1 year ago 30,315 pass, 2 fail - last update
over 1 year ago 30,322 pass - last update
over 1 year ago 30,322 pass - last update
over 1 year ago 30,322 pass - last update
over 1 year ago 30,322 pass - last update
over 1 year ago 30,322 pass - last update
over 1 year ago 30,322 pass - last update
over 1 year ago 30,325 pass - last update
over 1 year ago 30,330 pass - last update
over 1 year ago 30,330 pass - last update
over 1 year ago 30,330 pass - last update
over 1 year ago 30,330 pass - last update
over 1 year ago 30,334 pass - last update
over 1 year ago 30,334 pass - last update
over 1 year ago 30,334 pass 25:53 24:36 Running- last update
over 1 year ago 30,334 pass - last update
over 1 year ago 30,334 pass - last update
over 1 year ago 30,334 pass - last update
over 1 year ago 30,335 pass - last update
over 1 year ago 30,335 pass - last update
over 1 year ago 30,335 pass - last update
over 1 year ago 30,335 pass - last update
over 1 year ago 30,335 pass - last update
over 1 year ago 30,338 pass - Status changed to Needs work
over 1 year ago 4:40pm 7 June 2023 - 🇺🇸United States Amber Himes Matz Portland, OR USA
Looks like this MR needs to be rebased onto 9.5.x, as the merge is currently blocked according to the MR in GitLab. (Clicking the Rebase button didn't work for me.)
- First commit to issue fork.
- last update
about 1 year ago 30,338 pass - Status changed to RTBC
about 1 year ago 1:00pm 13 June 2023 - 🇺🇸United States pyrello
I was able to rebase the MR, so I undid the issue tags and status changes. To be able to rebase the MR, I had to click the "Get push access" under the issue summary.
I'm uploading a file-based patch to use for my team's project, which can safely be ignored.
- last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,341 pass - last update
about 1 year ago 30,337 pass, 2 fail - Status changed to Needs work
about 1 year ago 12:45pm 11 July 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
FEFM here. I agree that having the
all: initial;
after many lines of styles was a poor implementation that needs fixing. I'm also concerned that making such a change is potentially disruptive in a way that breaks the "fence" promised by Stable themes.There are sites/themes that may experience regressions if this (clearly not-ideal) CSS changes. Among other things, there may be styles that While it's true the issue fixed here could be classified as a bugfix, there may be themes based on Stable that now expect the
content-box
sizing.I would immediately sign off on a version of this that changed the /core CSS but not the Stable theme CSS. To change Stable I think there would need to be a deeper risk/benefit assessment. Perhaps the core change can happen here, and the potentially longer discussion of updating Stable can be done in a followup.
- Status changed to Closed: outdated
3 months ago 1:59pm 14 June 2024 - 🇮🇪Ireland markconroy
I'm going to close this issue since it belongs to Drupal 9.5 which is no longer supported and our `/core/.stylelint.json` file for D10/D11 does not include the `all` property. in the "order/properties-order" definition.
===
Thanks to Code Enigma for sponsoring my time to work on this.