Fix the issues reported by phpcs

Created MR , please review.

Thank you.

Hi,

I have reviewed MR, it removed all the phpcs errors and warnings but these changes doesn't seems correct to me:

1. For example: t() calls, it should be $this->t() not $this() here:

diff --git a/src/ViewsUiFormService.php b/src/ViewsUiFormService.php
-    $perms = ['' => t('- None -')];
+    $perms = ['' => $this('- None -')];

2. Doc comment short description should explain what the function is actually doing not the function name as it is here:

diff --git a/views_field_permissions.install b/views_field_permissions.install
- * Update views configs to guarantee retrocompatibility for the role-based
- * permission feature.
+ * Summary of views_field_permissions_update_8001.

3. For line exceeds 80 characters, break the sentence just once it's reaching 80 characters, not from anywhere. Like here:

diff --git a/views_field_permissions.module b/views_field_permissions.module
-            // Save the new settings, log the change, and mark the view for update.
+            // Save the new settings, log the change,
+            // mark the view for update.

It should be:

+            // Save the new settings, log the change,  mark the view for
+            // update.

Thanks & Regards,
Mrinalini

I am going to review the MR3. (It is not clear whether MR5 was created to fix something that MR3 did not fix.)

-    // Get list of permissions
-    $perms = ['' => t('- None -')];
+    // Get list of permissions.
+    $perms = ['' => $this->t('- None -')];
     $permissions = $this->permissionHandler->getPermissions();

That comment can be removed, since it describes something the code makes already clear.

-            // Save the new settings, log the change, and mark the view for update.
+            // Save the new settings,log the change,and mark the view for
+            // update.

In English, there must be a space between a comma and the word following it.

     $form['options']['expose']['views_field_permissions'] = $elements;
     $form['actions']['submit']['#submit'][] = [get_class($this), 'submit'];
+
+    return $form;

A method that is declared as public function form(array &$form, FormStateInterface &$form_state) does not need to return $form.

Also, the report shows errors/warnings for five files, but MR5 just changes a single file.

Hi @everyone,

All issues mentioned were fixed after #16's MR!5 commit

drupal-orgissue git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_field_permissions
➜  drupal-orgissue git:(main) ✗

Moving this to RTBC.

Thanks,
Jake

apaderno → changed the visibility of the branch 3339907-drupal-coding-standards to hidden.

These issues has been already fixed in 📌 Automated Drupal 10 compatibility fixes Fixed . GitLab CI does not show any PHP_CodeSniffer warning/error that should be fixed.