- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:38am 7 February 2023 - Assigned to Sonal Gyanani
- @sonal-gyanani opened merge request.
- Issue was unassigned.
- ๐ฎ๐ณIndia Sonal Gyanani
Patch #2 applied successfully, all errors and warnings are fixed
RTBC +1 - Assigned to Charchil Khandelwal
- Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 1:38pm 7 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
MR !16 looks good to me.
All the errors and warnings are fixed.
So moving it to RTBC.Thanks.
- Status changed to Needs work
almost 2 years ago 11:31pm 8 February 2023 - ๐บ๐ธUnited States rymcveigh
These changes seem great. I just had one comment on the MR. Are you okay if we use
protected TimeInterface $time;
for consistency throughout the module's codebase? - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Ashutosh Ahirwal โ made their first commit to this issueโs fork.
- last update
over 1 year ago 1 pass - Status changed to Needs review
over 1 year ago 9:35am 18 May 2023 - Status changed to RTBC
over 1 year ago 8:32pm 23 May 2023 - ๐บ๐ธUnited States rymcveigh
I tested these changes locally and they look great. I used the following to test:
- Ran PHPCS
- Created a wizard webform on a vanilla Drupal 10 install
- Ran a series of Behat tests with the changes on an existing site using these changes.
These changes look good to me.
- last update
over 1 year ago 1 pass -
rymcveigh โ
committed 739b01a4 on 2.0.x authored by
Sonal Gyanani โ
Issue #3339799 by Sonal Gyanani, samit.310@gmail.com, Ashutosh Ahirwal,...
-
rymcveigh โ
committed 739b01a4 on 2.0.x authored by
Sonal Gyanani โ
- Status changed to Fixed
over 1 year ago 8:33pm 23 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.