- Issue created by @gawalin
- ๐ท๐บRussia znaeff
Hello.
Please give us a few days to investigate the issue.
- ๐ท๐บRussia znaeff
Hello.
Thank you for your feedback.
We'll do our best to fix the issue as soon as possible.
Sorry for the inconveniences.
- ๐บ๐ธUnited States bsufan17
Having a similar issue but a different error message.
Call to undefined method Cleantalk\Custom\Helper\Helper::obfuscate_param() in Cleantalk\Custom\Helper\Helper::get_fields_any()
- ๐ท๐บRussia znaeff
Hello @bsufan17
We've fixed the issue:
https://git.drupalcode.org/project/cleantalk/-/commit/a772a84805c5c6fec0...The patch is attached.
Does it work?
- ๐ท๐บRussia znaeff
Hello @gawalin @tjtj
Unfortunately, your issue is more complicated. We need more details to fix it.
Please contact us via our support system:
https://cleantalk.org/my/support/openThank you.
- ๐บ๐ธUnited States bsufan17
@znaeff, yes, the patch worked. Thanks for the quick response!
- ๐บ๐ธUnited States tjtj
This still happened when I updated to today's 9.2.2
- ๐ท๐บRussia znaeff
Hello, @tjtj
We've received your message in our ticket system.
Let's continue our conversation there.
- ๐จ๐ฆCanada OMD
Having the same issues. Updated to 9.2.3 since it looked like it contained the patch, but error is still there complete with "The website encountered an unexpected error. Please try again later." on save config page.
and in logs:
Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupal.cleantalk_ua_bl' doesn't exist: TRUNCATE TABLE cleantalk_ua_bl; Array ( ) in Cleantalk\Custom\Db\Db->execute() (line 44 of /var/www/html/drupal/web/modules/contrib/cleantalk/lib/Cleantalk/Custom/Db/Db.php).
- ๐ท๐บRussia znaeff
Hello,
We are still working on this issue. We will inform you
- ๐ธ๐ฎSlovenia joco_sp
This is probably a problem, because the table prefix is missing when table_name is called.
Possible the same issue as here - https://www.drupal.org/project/cleantalk/issues/3211127 ๐ Firewall Class doesn't use db table prefix RTBC
- ๐ท๐บRussia znaeff
We plan to release a new version with the fixes within 1-2 months. You can try to re-install the plugin. Some users reported that it helped
- ๐ท๐บRussia znaeff
Hello @gawalin
Please install this version of the plugin. This contains edits for PostgreSQL compatibility:
https://git.drupalcode.org/project/cleantalk/-/tree/pgsql - ๐ท๐บRussia _kom__
Today I've renewed my subscription to extended package (AntiSpam + Security) and found that SpamFirewall still doesn't work (no log messages in Dashboard, bruteforce attacks still appear in Watchdog).
I've noticed that SpamFirewall checkbox in Cleantalk settings is still turned on (it was turned on for years when previous subscription was active).
So I've tried to "reload" configuration on my side via unchecking/checking again this checkbox.
Disabling of SpamFirewall proceeded after click on "Save" button, Settings page reloaded and checkbox became unchecked (of course, active module configuration changed).
But. After trying to re-enable SpamFirewall I've got mentioned above error - and one more warning:
Warning: mkdir(): Permission denied ะฒ Cleantalk\Common\Firewall\FirewallUpdater->prepareUpdDir() (ัััะพะบะฐ 705 ะธะท /var/www/drupal/public_html/modules/contrib/cleantalk/lib/Cleantalk/Common/Firewall/FirewallUpdater.php)
After reload of Settings page checkbox remained unchanged, active configuration (with disabled SpamFirewall) too.
So I had to import old saved configuration to return system in previous state.Please, show me the right way: what shall I do and how to make SpamFirewall work:
- Use the suggested patch
- Try to reinstall module
- Stop using Cleantalk and totally remove all it's code from my computers :)Thank you.
My environment is: Cleantalk 9.2.3 and Drupal 9.5.9.
- ๐ท๐บRussia znaeff
Hello.
When you activate the SpamFireWall, a new folder is created in the plugin folder. This operation causes an error. You should add write permissions inside the plugin folder.
Did it help?
- ๐ท๐บRussia _kom__
Yes, it helps to disable/enable firewall and changes configuration. But.
It is a very bad practice to enable webserver write permissions in any Drupal place except specially allowed (e.g. sites/default/files/). Please, look here https://www.drupal.org/docs/administering-a-drupal-site/security-in-drup... โ .
Moreover, it can cause Composer integrity issues when local changes take place in directories that are under it's control.
What is the role of this folder? What files will appear there? Is there any special reason to put them in module directory? - ๐ท๐บRussia znaeff
The files in this folder are needed for the operation of the firewall itself and for updating the firewall database. FireWall won't work without the ability to modify files in this folder.
Thank you.
- ๐ท๐บRussia _kom__
@ znaeff it is absulutely clear, the question was why you select so unfavourable place for storage? There is a lot of practical solutions for such folders in Drupal core (js, css or php/twig folders) or in wide range of contributed modules (see, for example Asset Injector or Color modules). All these use common default/files folder.
- ๐ท๐บRussia znaeff
We'll discuss what can be changed to this folder.
Please give us 2-3 business days.
- ๐บ๐ธUnited States tjtj
Still get this error after patch#8 when I try to put the key into the cleantalk configuration page.
Drupal\Core\Database\DatabaseExceptionWrapper:
SQLSTATE[42S02]: Base table or view not found: 1146
Table 'stelnews_d10.cleantalk_sfw_logs' doesn't exist:
SELECT * FROM cleantalk_sfw_logs; - ๐ท๐บRussia _kom__
@znaeff, hope you'll find appropriate and secure solution.
I have given all necessary permissions to Cleantalk module folder and for cleantalk_fw_files folder, but there is still no files in it. And SpamFireWall still doesn't work: there is again no records in dashboard.
Should I create support request via my account? Maybe something went wrong on your side? - ๐ท๐บRussia znaeff
@tjtj Do you use PostgreSQL? Could you try this version?
- ๐ท๐บRussia znaeff
@_kom__ we will discuss this with our developers, please wait
- ๐ท๐บRussia _kom__
I've found that directory cleantalk/cleantalk_fw_files is created by webserver only for a few seconds, then server deletes it. But now I've got
Warning: file_put_contents(/var/www/drupal/public_html/modules/contrib/cleantalk/cleantalk_fw_files/index.php): Failed to open stream: Permission denied ะฒ Cleantalk\Common\Firewall\FirewallUpdater->prepareUpdDir() (ัััะพะบะฐ 714 ะธะท /var/www/drupal/public_html/modules/contrib/cleantalk/lib/Cleantalk/Common/Firewall/FirewallUpdater.php)
I think that is also due to improper location of created directory and the reason is that files/folder owner and webserver are not the same in my case.
However, further consideration is out of this issue, I'll create a new topic for this special case.
- ๐ท๐บRussia znaeff
Thank you for the additional details.
I've added them to the task.
For now, you can try to disable spamfirewall.
- ๐ท๐บRussia znaeff
Hello.
We made fixes. Now the temporary directory cleantalk_fw_files will be created and deleted in the standard directory for files.
I'm attaching the patch with the changes.
Please check the results.
- ๐จ๐ฆCanada b_sharpe
What in the hell is happening with the install file??? No wonder some of these tables are broken
```
cleantalk_update_926
cleantalk_update_9124
cleantalk_update_9118
cleantalk_update_91115
``` - ๐บ๐ธUnited States serge-m
We check the installation file within 3 business days.
Please, wait. - ๐ท๐บRussia znaeff
Hello @b_sharpe,
Thank you for waiting.Could you tell us what you downloaded? We've attached a patch, not an installation file. Applying a patch is different from installing the installation file.
If you still have this issue, please tell us step-by-step how to reproduce it.
- ๐จ๐ฆCanada blainelang
Also had a site go down running 9.2.7 on D 9.5.11 and PHP 8.1.24
Required a full database restore. We are also seeing the Undefined Array issue and it's filling up our logs on multiple sites: https://www.drupal.org/project/cleantalk/issues/3383492 ๐ Undefined array key Needs review
I'm recommending the client un-install the module until this is resolved with a new version.
- ๐ท๐บRussia znaeff
Hello @blainelang,
Have you tried applying patches from here
https://www.drupal.org/project/cleantalk/issues/3339276#comment-15128399 ๐ The website encountered an unexpected error. Please try again later. Active https://www.drupal.org/project/cleantalk/issues/3383492#comment-15279553 ๐ Undefined array key Needs review ? - ๐จ๐ฆCanada blainelang
@znaeff, no I have not. The client has not authorized me to do so. I want you and others to know this is a more serious issue and bringing sites down!
- ๐จ๐ฆCanada blainelang
The patch in #33 appears to be written for a different version of cleantalk and will not apply with composer. We are using version 9.2.7 - latest at this point in time. This issue was created in Aug with version 9.2.5.
Maybe you can also help us by explaining how the getUpdatingFolder() would trigger a SQL error - just curious.
Thanks @znaeff for the quick response on a weekend!
- ๐ท๐บRussia znaeff
blainelang, we will answer your question within 3 business days.
- ๐ท๐บRussia znaeff
blainelang, unfortunately, we cannot repeat and fix the issue in our environment. We need more information about your site. Please contact us via our private Ticket System: https://cleantalk.org/my/support/open.
- ๐จ๐ฆCanada blainelang
@znaeff, you asked me about trying the patch in #13 but it would not apply. Can you update the patch for version 2.7".
Was that patch not related to the issue I posted?As stated in other issues, the Drupal community prefers to discuss and resolve issues about modules here and not in private.
Hello, @blainelang, @tjtj, @b_sharpe, @_kom_
It seems the table is not being updated correctly since Feb 23.
We going to do a lot of refactoring in the next two weeks.
Then new major version will be issued. Right now we stopped to perform any patches for Drupal issues to keep the integrity of the new release. Please wait.
If it is applicable, you can downgrade cleantalk version to 9.2.3, as we were informed, there is no tables issues on this version.
If this is not helpful, remove all cleantalk tables and do clear install of 9.2.3
List of tables:
- cleantalk_ac_logs
- cleantalk_sessions
- cleantalk_sfw
- cleantalk_sfw_logs
- cleantalk_sfw_temp
- cleantalk_timelabels
- cleantalk_ua_bl
Also remove cleantalk_cron key from state collection in key_value table.
We are really sorry for this mess.
- ๐ท๐บRussia znaeff
Hello, @blainelang, @tjtj, @b_sharpe, @_kom_
It seems the table is not being updated correctly since Feb 23.
We going to do a lot of refactoring in the next two weeks.
Then new major version will be issued. Right now we stopped to perform any patches for Drupal issues to keep the integrity of the new release. Please wait.
If it is applicable, you can downgrade cleantalk version to 9.2.3, as we were informed, there is no tables issues on this version.
If this is not helpful, remove all cleantalk tables and do clear install of 9.2.3
List of tables:
- cleantalk_ac_logs
- cleantalk_sessions
- cleantalk_sfw
- cleantalk_sfw_logs
- cleantalk_sfw_temp
- cleantalk_timelabels
- cleantalk_ua_bl
Also remove cleantalk_cron key from state collection in key_value table.
We are really sorry for this mess.
- ๐จ๐ฆCanada b_sharpe
The work-around for me was to just force a re-run of the updates that were supposed to create those tables, the issue is the update hooks are incorrectly named making certain ones get skipped depending on what version you came from.
You can see the issue here in the naming of the update hooks:
cleantalk_update_926 cleantalk_update_9124 cleantalk_update_9118 cleantalk_update_91115
If you rerun 91115 you will get your tables.
- ๐บ๐ธUnited States serge-m
Hello,
We have fixed the issues and released a new version 9.3.0:
https://www.drupal.org/project/cleantalk/releases/9.3.0 โPlease, update the module and clear your website cache.
Did it help?