- Issue created by @samata soni
- @samata-soni opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 7:09am 4 February 2023 - Status changed to Needs work
almost 2 years ago 8:03am 6 February 2023 - ๐ต๐ฑPoland Graber
This readme doesn't describe what the module does, looks just like a template with filled placeholders. If you want credit for this issue and to be considered as a contributor in any future issues in my projects, please install the module, see what it does and write a dedicated README.
- First commit to issue fork.
- last update
about 1 year ago 72 pass - Status changed to Needs review
about 1 year ago 7:40am 8 December 2023 - thakurnishant_06 India
Updated Fork and added Readme.md file.
Kindly review the changes. - ๐ต๐ญPhilippines kenyoOwen
Hi thakurnishant_06
I reviewed your MR!9 and it follows the README.md template. โ
+1 RTBC
Thank you
- Status changed to Needs work
11 months ago 9:57am 16 January 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!3, the patch is not cleanly applied.
a) 3.diff.txt:19: trailing whitespace. ## Contents of the file 3.diff.txt:28: trailing whitespace. 3.diff.txt:30: trailing whitespace. 3.diff.txt:31: trailing whitespace. 3.diff.txt:45: trailing whitespace. warning: squelched 1 whitespace error warning: 6 lines add whitespace errors. b) Use "## Table of contents" instead of "## Contents of the file "
c) Bulleted lists denoted by dashes (-), so please remove hyphen from Requirement, installation, maintainers, configuration.
d) Remove the text Current maintainer from maintainer section, there we only mention current maintainers. - ๐ฎ๐ณIndia mohd sahzad
Mohd Sahzad โ made their first commit to this issueโs fork.
- last update
11 months ago 72 pass - last update
11 months ago 72 pass - Status changed to Needs review
11 months ago 9:44am 18 January 2024 - last update
11 months ago 72 pass - thakurnishant_06 India
thakurnishant_06 โ changed the visibility of the branch 3339097-added-readme.md-file to hidden.
- thakurnishant_06 India
thakurnishant_06 โ changed the visibility of the branch 1.0.x to hidden.
- Status changed to RTBC
11 months ago 12:36pm 21 January 2024 - ๐ฎ๐ณIndia Bushra Shaikh
I verified and applied MR !9, and the README.md file added successfully after applying this patch.
Adding screenshots for reference.Can be move to RTBC+1
- ๐บ๐ธUnited States arnoldbird
The README in #15 does not explain how to use the module. It says,
3. Inside the View editor, find the section that lists the exposed filters.
Why "find the section"? Why not refer to the specific part of the GUI that you have in mind? Is it the "Exposed Form" section? Is it the "Filter Criteria" section? Which is it?
4. After adding the Views Date Filter, configure its settings based on your requirements
After adding the Views Date Filter? You skipped telling us *how* to add the Views Date Filter. I can't figure it out. After enabling the module, I don't see any reference to a "Views Date Filter" anywhere in the view settings.
- Status changed to Needs work
8 months ago 12:16pm 1 May 2024 - Assigned to diwakar07
- last update
7 months ago 72 pass - Issue was unassigned.
- Status changed to Needs review
7 months ago 8:01am 21 May 2024 - ๐ฎ๐ณIndia diwakar07
Hi @arnoldbird, @Graber
I have updated the configuration section for the README.md file based on the feedbacks.
Please review. - Status changed to Needs work
7 months ago 5:59am 24 May 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi Diwakar07
I reviewed your changes, minor issues. Missing a dot in
eg.
it should bee.g.
#4 of the configuration section, anddatepicker calender
should beDatepicker calendar
.Thanks,
Ken. - last update
7 months ago 72 pass - Status changed to Needs review
7 months ago 6:48am 24 May 2024 - ๐ฎ๐ณIndia diwakar07
Hi @kenyoOwen,
I have updated the same.
Please review. - Status changed to RTBC
7 months ago 7:15am 28 May 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi Diwakar07
I reviewed your changes and confirmed that it fixed the comment #20 and it follows the README.md template.
Thanks,
Ken. - last update
7 months ago 72 pass -
Graber โ
committed 6b95425a on 1.0.x authored by
thakurnishant_06 โ
Issue #3339097 by Samata Soni: Missing README.md file
-
Graber โ
committed 6b95425a on 1.0.x authored by
thakurnishant_06 โ
- Status changed to Fixed
7 months ago 9:39am 3 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.