- Issue created by @akshay.kelotra
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:40am 31 January 2023 - š®š³India akshay.kelotra Indore
I have fixed this issue and providing a patch.
- Assigned to Charchil Khandelwal
- @charchil-khandelwal opened merge request.
- Issue was unassigned.
- š®š³India Charchil Khandelwal
Created MR for this issue.
Please review. - Status changed to Needs work
about 1 year ago 11:39am 10 June 2023 - š®š¹Italy apaderno Brescia, š®š¹
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
- Status changed to Needs review
about 1 year ago 6:13am 15 June 2023 - š®š³India Ashutosh Ahirwal India
Hi,
I have added the command and arguments has been used for this issue.
Please review.phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,css,js,txt,md,yml web/modules/custom/image_slideshow_demo
- Status changed to RTBC
about 2 months ago 7:26am 19 July 2024 Hi @akshay.kelotra,
I applied the patch you provided, it was applied successfully but there are still errors reported. Please see below:
image_slideshow_demo git:(main) curl https://www.drupal.org/files/issues/2023-01-31/drupal-coding-standard-issue-3337843-1.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 342k 100 342k 0 0 397k 0 --:--:-- --:--:-- --:--:-- 404k patching file new_custom_pdp/css/bootstrap.min.css patching file new_custom_pdp/css/new.css patching file new_custom_pdp/css/owl.carousel.min.css patching file new_custom_pdp/css/owl.theme.default.min.css patching file new_custom_pdp/new_custom_pdp.install patching file new_custom_pdp/new_custom_pdp.module ā image_slideshow_demo git:(main) ā cd .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig image_slideshow_demo FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/image_slideshow_demo/new_custom_pdp/config/install/field.storage.node.field_zoom.yml ------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------- 30 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/image_slideshow_demo/new_custom_pdp/new_custom_pdp.libraries.yml ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/image_slideshow_demo/new_custom_pdp/new_custom_pdp.info.yml ------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------ 8 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ Time: 126ms; Memory: 10MB
On the other hand, I applied the changes @Charchil Khandelwal's made on MR!1, it was also applied successfully and it did fix all reported errors.
image_slideshow_demo git:(main) curl https://git.drupalcode.org/project/image_slideshow_demo/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 344k 0 344k 0 0 657k 0 --:--:-- --:--:-- --:--:-- 675k patching file new_custom_pdp/config/install/field.storage.node.field_zoom.yml patching file new_custom_pdp/css/bootstrap.min.css patching file new_custom_pdp/css/new.css patching file new_custom_pdp/css/owl.carousel.min.css patching file new_custom_pdp/css/owl.theme.default.min.css patching file new_custom_pdp/new_custom_pdp.info.yml patching file new_custom_pdp/new_custom_pdp.install patching file new_custom_pdp/new_custom_pdp.libraries.yml patching file new_custom_pdp/new_custom_pdp.module ā image_slideshow_demo git:(main) ā cd .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig image_slideshow_demo ā contrib git:(main) ā
Will now move this to RTBC
Thanks,
Jake- Status changed to Needs work
about 2 months ago 9:10am 19 July 2024 - š®š¹Italy apaderno Brescia, š®š¹
Let's create a merge request, now that patches are no longer tested.
- š®š¹Italy apaderno Brescia, š®š¹
The bad news is that, since the existing merge request changed the main branch, its changes are kept on any new branch created on this issue, which is bad, since that merge request changed files that should not have been changed, like the new_custom_pdp/css/bootstrap.min.css file.
The only way to create a correct merge request is to create a new issue.
- Status changed to Closed: duplicate
about 2 months ago 12:00pm 19 July 2024