CSpell dictionary is out of sync

Change looks good.

It took about 90s to run the command on my local `yarn spellcheck:make-drupal-dict`. So, is it necessary/worth writing a test to avoid regression?

Agreed, but over in [#336828-6] and [#336828-7] it looks like it was decided it's taking too long. 🐛 File dictionary.txt is not sorted Fixed

In the 10.x patches:

+++ b/core/misc/cspell/dictionary.txt
@@ -302,6 +300,7 @@ dependees
+derp

Where is this coming from, and why isn't it currently picked up as an error?

Good questions @longwave (rather unsurprising, since that's usually the case).

Where is this coming from

This seems to be coming from here: https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/tests/Drupa...

and why isn't it currently picked up as an error?

Since it's been there since 14/11/2012, I can only imagine we upped our CSpell version (on 10.x) at some point in time and did _not_ ran a yarn spellcheck:make-drupal-dict afterwards.
In that new version, somehow somewhere, derp got deleted from a dictionary within CSpell.

Afterwards the file never changed, so was never checked by CSpell and was never flagged for the, now unknown, word "derp".

I think if we can make core/scripts/dev/commit-code-check.sh do a yarn spellcheck:make-drupal-dict whenever the version of CSpell is bumped, we'll never have this problem again.

Since we basically only bump (nodeJS)-dependencies just before a new release, it's a rather rarely occurring event, so that might weigh up against the time we would need to spend to do a yarn spellcheck:make-drupal-dict?

We also need to rebuild the dictionary when cspell.json changes, #3308419-22: Use all the included dictionaries with cspell →

Tagging for a followup to make sure the dictionary is rebuilt when needed.

Thanks @quietone, makes perfect sense.

I've opened 📌 Run CSpell on all files when CSpell-related files change Active for that, removing Needs followup tag.

Follow-up is a good idea.

Committed/pushed the respective three patches to the respective three branches, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.