File dictionary.txt is not sorted

CSpell/SortTest shows that the file contains a list that is not sorted correctly.

Adding changes to the list makes the test passing.

The dictionary generator is supposed to sort the file, but the error proves that we must have merged some changes manually; so the test is good to ensure that it stays sorted.

A few nitpicks in the test but overall this looks great.

The dictionary generator is supposed to sort the file, but the error proves that we must have merged some changes manually;

Aren't we fighting the symptom here?

Maybe we can trigger a yarn spellcheck:make-drupal-dict in commit-code-check.sh on all files if dictionary.txt changes?
If the the new dictionary is different from the one in the patch/MR then fail and we should be fine?

yarn spellcheck:make-drupal-dict is quite slow, this test should be quick. I also think there are still some locale issues with the dictionary generator, as the accented characters sometimes change for reasons I don't yet understand, and regenerating on DrupalCI might trip this up further.

Having just written #7 it strikes me that the issue might be that we need to apply LC_ALL=C to the tr command as well as the sort command.

Thanks for the review, I addressed all review comments.

Thanks, this looks OK to me and will prevent regressions here in the future.

Rebased after 📌 CSpell dictionary is out of sync Fixed

I was tempted to agree with Spokje that we could skip this step and go straight to 📌 Run CSpell on all files when CSpell-related files change Active ... but cherry-picks bypass core commit checks, so this should catch situations where we're introducing discrepancies between 10.1.x and 10.0.x (although only post commit so if it happens we'll need to hotfix it).

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

If all the commits are done, can the MR be closed as it was not actually merged here.

voleger → closed merge request !3305