Warnings for empty table - header/empty rows

Thank you @diqidoq

Makes sense, in the meantime while migrating some D7 sites we continue maintaining and removing warning. Posting here so there is reference and a link to pull the patch.

The following patch resolves the same issue but for the 2013 D7 version - instead of the D7 dev.

Regards,
Blanca

Thanks for your awesome work on this Blanca! +1 If you have some spare time, would you mind to provide a patch against latest 2.x dev too? I would love to add it if it is still required there.

Rerolled patch for the 2.x branch, please review it.

Thanks!

Agree with this patch. It can be applied to 2.x-dev. 2 parts over 3 compared to patch #6 🐛 Warnings for empty table - header/empty rows Fixed since the last part does not exist any more in the target file.

In fact there is a problem with the patch #9 → since it produces an error with Drupal 9.5.8,

The website encountered an unexpected error. Please try again later.
Error: Call to undefined function drupal_clean_css_identifier() in template_preprocess_views_view_datatables() (
line 55 of modules/contrib/datatables/datatables.module).

Change drupal_clean_css_identifier to Html::cleanCssIdentifier. Here the new patch for 2.x-dev.
The same problem exists for the others versions.

RTBC for 11.

use Drupal\Component\Utility\Html;

is already present in the file.

@diqidoq any chance to review and merge this?

PS: My offering for help as co-maintainer still stands :)

@Chris64 could you eventually prepare #11 as MR here to speed things up?

Chris64 → closed merge request !9

Chris64 → reopened merge request !9

Confirming RTBC for MR!9!

@diqidoq any plans for an RTBC-sprint and D10 compatible stable release?

The sprint is already going on since 24 hours ;-) ... I had my drugs and the next release is coming up soon, hah!

This is the 3rd last of 8 RTBC's today. Let's wait and see if I can keep up this night until the morning for another release ;-)

Thanks to Blanca.Esqueda, Chris64, himanshu_jhaloya, mrinalini9, Anybody! Merged and queued for next release! Thanks to all working on this!

Automatically closed - issue fixed for 2 weeks with no activity.