- Merge request !2Issue #3335143: Update README.md file according to "README.md template" โ (Merged) created by Charchil Khandelwal
- ๐ฎ๐ณIndia Nupur Badola
Patch is failed and getting the error.
error: patch failed: README.md:1 error: README.md: patch does not apply
- Status changed to Needs work
over 1 year ago 9:41am 26 July 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Charchil Khandelwal
I applied and reviewed your MR and it is not following the README.md template. Missing Table of contents and Maintainer section. Wrong information in the "Installation" section should be like this as per the README.md template.
Install as you would normally install a contributed Drupal module. For further information, see [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
- ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
over 1 year ago 12:53pm 26 July 2023 - Status changed to Needs work
over 1 year ago 3:02pm 8 August 2023 - Status changed to Needs review
12 months ago 11:19am 6 December 2023 - Status changed to RTBC
12 months ago 2:59am 7 December 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Anjali Mehta
I reviewed your changes and it looks good to me and it follows the README.md template. โ
Thank you
- Status changed to Needs work
12 months ago 8:44am 7 December 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
12 months ago 9:03am 7 December 2023 - Status changed to RTBC
12 months ago 12:18pm 19 December 2023 - ๐ฎ๐ณIndia Nupur Badola
@apaderno I have reviewed MR!2, the issues you have mentioned are not fixed. Hence marking it to RTBC.
- First commit to issue fork.
-
nickdickinsonwilde โ
committed cb862d19 on 1.0.x authored by
Charchil Khandelwal โ
Issue #3335143 by nitin_lama, Charchil Khandelwal, anjali mehta,...
-
nickdickinsonwilde โ
committed cb862d19 on 1.0.x authored by
Charchil Khandelwal โ
- ๐จ๐ฆCanada nickdickinsonwilde Victoria, BC (T'So-uke lands)
Thanks for the readme improvements.
Automatically closed - issue fixed for 2 weeks with no activity.