Use GET method as fallback if HEAD fails

Livecan → closed merge request !37

Livecan → closed merge request !42

Sorry, had some problems with figuring out submitting my changes to the project. I hope now it should be really ready to merge.

Switched to 2.0.x branch and added a new branch and merge request for this feature.

I agree this still makes sense as option, as several hosts refuse HEAD calls, for example:

• Google
• Amazon
• Facebook
• Pexels
• ...

Which leads to failing / false-positive broken link checkes especially in the imprint.

@bwaindwain could you change the target branch to 2.1.x please?

Implementation looks nice, we should get this over the finish line! :)

I also left a comment in code.

I tried this and for many links it works and links are marked correct now. But some still are marked failed, for example:

• https://www.pexels.com
• https://pixabay.com/

Yes, EXACTLY this URLs! Give it a try. Any idea for the reasons, if it's already GET, not HEAD?

konot → changed the visibility of the branch 3334240-use-get-method to hidden.

konot → changed the visibility of the branch 3334240-use-get-method to hidden.

try 'GET' if 'HEAD' fails

joseph.olstad → made their first commit to this issue’s fork.

@xfxfca ,
Please back off your patch and try out https://git.drupalcode.org/project/linkchecker/-/merge_requests/120.patch

updated patch

Rerolled and combined:
#3334240-28: Use GET method as fallback if HEAD fails →

with

#3213210-46: provide optional host and port substitution to check links behind a reverse proxy and/or docker environment →

in MR 121.

Please review MR 120.

joelpittet → changed the visibility of the branch 2.0.x to hidden.

joelpittet → changed the visibility of the branch 3334240-use-get-method-2 to hidden.

There are quite a few proposed solutions here, and it’s not clear which one is meant to move forward. I hid two that looked like accidental MRs (hopefully correctly!).

The issue summary is excellent though! Short, clear, and the title is specific. That really helps. Let’s make it easy for maintainers to commit something.

@joseph.olstad instead of me trying to guess, maybe you could hide any MRs/branches we no longer need? If you’re combining approaches, a patch might be a better fit anyway, since it’s composer-patchable and avoids branch clutter.

I think most of this confusion came from creating a 2.0.x target branch on a fork that didn’t already have it — GitLab makes you create it before you can select it as the MR target, which unintentionally makes it look like it’s part of the issue work. (I still haven’t figured out how to avoid that either.)

joseph.olstad → changed the visibility of the branch 3334240-get-method-fallback-with-3213210-host-port-substitution to hidden.

I will argue that MR 56 is not needed since linkchecker already offers a domain blacklist to handle the option.

MR 121 has been extensively tested and also passes automated testing.

joseph.olstad → changed the visibility of the branch 3334240-use-get-method-2.0.x to hidden.

Let’s make this simple, which MR only does what the issue summary and title asks of it and doesn’t creep on scope?

Answer: MR 121 and it is the only currently visible MR

Thanks @joseph.olstad I will reviewMR 121 later, first glance the test could use something a bit more explicit, but I will look closer as there is probably context lines that make it clearer already in place.

The code looks great I should add, I am mostly concerned about the test

correction MR 120