Fix the issues reported by phpcs

It would be better if the MR is reviewed by somebody who does not work on the same organization.

Hi samit.310@gmail.com,

I applied your patch #2 to Search Overrides module against version 2.1.x-dev and I confirmed that the PHPCS issues were fixed.

Please look at the screenshots attached for your reference

Thank you

-    // Only load one entity per term, to reduce complexity
-    // TODO: prevent duplicates from being stored.
+    // Only load one entity per term, to reduce complexity.
+    // @todo prevent duplicates from being stored.

What follows @todo is a sentence: It starts with a capitalized word and it ends with a period (preferable), a question mark, or an exclamation point.

+/**
+ * Function search_overrides_get_indexes.
+ */
 function search_overrides_get_indexes() {

Assuming that is not a hook implementation, its documentation comment must:

• Describe the function purpose, not start with Function and repeat the function name
• Describe any parameter it gets and their type
• Describe the return value

+  /**
+   * Constructs a new Manager instance.
+   *
+   * @param \Drupal\Core\Render\RendererInterface $renderer
+   *   The renderer.
+   * @param \Drupal\Core\Routing\RedirectDestinationInterface $redirect_destination
+   *   The redirect destination service.
+   */
+  public function __construct(RendererInterface $renderer, RedirectDestinationInterface $redirect_destination) {

The short description is missing the class namespace.

+  /**
+   * Function remove Entity.
+   */
   public function removeEntity($override, $entity, $field) {

It is not correct for the same reasons reported for the other change.

       '#ajax' => [
-        'callback' => [get_called_class(), 'processInput'], //alternative notation
-        'disable-refocus' => TRUE, // Or TRUE to prevent re-focusing on the triggering element.
+      // Alternative notation.
+        'callback' => [get_called_class(), 'processInput'],
+      // Or TRUE to prevent re-focusing on the triggering element.
+        'disable-refocus' => TRUE,
         'event' => 'click',
-        'wrapper' => 'search-overrides--data', // This element is updated with this AJAX callback.
+      // This element is updated with this AJAX callback.

Those comments are wrongly indented.

+  /**
+   * {@inheritdoc}
+   */
+  public function __construct(ConfigFactoryInterface $config_factory) {

{@inheritdoc} is not used for constructors.

 class SearchOverrideReferencer {
-  use StringTranslationTrait;
-
-  /**
-   * @var string
-   */
-  protected $entity_type_id;
-
-  /**
-   * @var int
-   */
-  protected $eid;
 
-  /**
-   * @var string
-   */
-  protected $keyword;
+  use StringTranslationTrait;

Why are those properties removed?

bindu r → made their first commit to this issue’s fork.