- Assigned to Sonal Gyanani
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:32am 17 January 2023 - Status changed to Needs work
almost 2 years ago 8:24am 17 January 2023 - Status changed to RTBC
almost 2 years ago 5:33pm 17 January 2023 - Status changed to Needs work
almost 2 years ago 11:39am 4 March 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ * @param string $form_id + * The form id. * * @return mixed + * Set the form options to the plugin.It should be form ID, not form id.
That is not a description for the return value.- if ($field_type == 'entity_reference' && (in_array($field->getSettings()['target_type'], ['node', 'media']))) { + $target_types = ['node', 'media']; + if ($field_type == 'entity_reference' && (in_array($field->getSettings()['target_type'], $target_types))) {The difference is a few characters in length that are probably not worth for such a change.
- First commit to issue fork.
- @kkalashnikov opened merge request.
- Status changed to Fixed
over 1 year ago 8:58am 27 May 2023 - 🇪🇸Spain alvar0hurtad0 Cáceres
Thanks for the suggestions to all.
I'm doing a deep re-architecture and your suggestions are make me think.For example this:
- if ($field_type == 'entity_reference' && (in_array($field->getSettings()['target_type'], ['node', 'media']))) { + $target_types = ['node', 'media']; + if ($field_type == 'entity_reference' && (in_array($field->getSettings()['target_type'], $target_types))) {Motivates this issue I've just created.
https://www.drupal.org/project/autotagger/issues/3363099 📌 Move source fields to an annotation Fixed Automatically closed - issue fixed for 2 weeks with no activity.