🇮🇳India @vinaygawade

I encountered the same issue, and applying this patch resolved it. Updating the status to RTBC.

After updating the core and other modules locally and running the update script, the Admin Toolbar Links Access Filter module was being uninstalled. Since the my custom module depended on it, it was also uninstalled, leading to the previously mentioned issue.
I fixed it now.

I updated my site from Drupal 10.3.* to Drupal 10.4.3 and ran updates, but I'm still encountering the following error:

Twig\Error\SyntaxError: Unknown "isTranslationMessageShouldDisplay" function. in Twig\ExpressionParser->getFunction()

Here’s how I defined the function:

/**
   * {@inheritdoc}
   * Returns custom Twig functions to Drupal.
   */
  public function getFunctions() {
    return [
      new \Twig\TwigFunction('get_display_name', [$this, 'get_display_name']),
      new \Twig\TwigFunction('isTranslationMessageShouldDisplay', [$this, 'isTranslationMessageShouldDisplay']),
    ];
  }

I have cleared the cache multiple times, but the issue persists. I'm not sure what is causing this error. Any insights would be appreciated!

Thank you, Klausi, for the review and feedback! I appreciate the account update and recommended readings. Grateful to the reviewers and the supportive Drupal community. Looking forward to staying involved!

The changes have been made as per your feedback:

1. The URL placeholder format now uses the correct syntax with `:variable` and is wrapped in double quotes, ensuring proper escaping and security.
2. Replaced `watchdog_exception()` with the injected logger service to maintain compatibility with Drupal 11 and follow modern Drupal logging practices.
3. Removed the redundant error logging to simplify and ensure clarity.

4. src/Form/SubscriptionForm.php
Is there any reason to use a separate class for the plugin form?
Using a separate class for the form ensures clean separation of responsibilities, making the code easier to maintain and reuse. It aligns with Drupal standards, allowing the form to be used in multiple contexts while keeping the block plugin focused on rendering. This approach keeps the module flexible, organized.

Thank you for the feedback.

1. The Twig file indentation has been updated to use two spaces as per Drupal standards.
2. The file header comment in the `.module` file has been revised to match the module name specified in the `.info.yml` file.

Let me know if any further changes are required.

Thank you for the feedback, and apologies for the late reply.
please check the 1.x branch for the latest changes and let me know if further adjustments are needed.
Once all reviews are complete, I will release the newer version.

vinaygawade → created an issue.

I've reviewed the changes and merged the request!

Thank you @vishalkadam for addressing the issues. I appreciate your prompt attention to these matters.

1. The incorrect branch "master" has been deleted, and the appropriate release branch has been created following the convention of ending with ".x".

2. The phpcs issue regarding the array declaration length has been fixed by splitting the array content over multiple lines, aligning with coding standards and enhancing code readability.

3. The constructor documentation comment has been adjusted to adhere to the specified format.

I've made these changes as requested. Could you please review them again to ensure they meet the project's standards? Thank you for your time and cooperation.

vinaygawade → created an issue.

Sure, please go ahead and do this `instead addStatus() please change as addError()` mentioned changes.

Thank you! @revathib, for reporting this bug. With your detailed description, I was able to identify and resolve the issue. Attached is the patch file for your review.

Thank You! @revathib

vinaygawade → made their first commit to this issue’s fork.

Here is the patch against 8.x-1.x branch.

Thank you @alex-bukach, Your given patch from #13 🐛 Deprecated error /PHP. 8.0 Drupal 9 Fixed is applied properly and removed all mentioned errors.