🇪🇸Spain @alvar0hurtad0

Thanks for the clarification, Stephen.

:)

Working on it.

Hi ,
I'd like to finish it, but I don't get your comment Smustgrave. I'm sorry if I'm doing anything incorrect.
If I'm should stop contributing here, please let me know. I just want to get more involved in code contributions, but I don't want to bother anyone.

Working on it.

alvar0hurtad0 → created an issue.

Hello,
Since a lot of things changed in the tests during the last 8 years I think we can focus on the scope of the issue and create a follow up issue to check if the component follows the recommendations in https://www.drupal.org/project/drupal/issues/2066993 🌱 Use \Drupal consistently in tests Needs work

I've created a MR with the requirements in this issue.

I should go slower.

wrong file. this one applies.

This patch makes possible to use captions.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → made their first commit to this issue’s fork.

Hi,

my apologies if I overstep. I was just trying to contribute a bit. I've a super tight schedule in my personal live and most of the contribution time that my employer give to me is spend in events organization and mentoring. So I saw something I can do in just a few minutes and I decided to go for it.

Sorry again if it was inappropriate.

Hi.
I've created a MR for this.

alvar0hurtad0 → made their first commit to this issue’s fork.

To add more context:

Less than 20 contrib modules are over 200.000 installs:
https://www.drupal.org/search/site/*?solrsort=iss_project_release_usage%... →

No contrib theme is over 200.000 installs:
https://www.drupal.org/search/site/%2A?solrsort=iss_project_release_usag... →

You're totally right, let's close this issue and create one in the project that it's actually responsible.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → created an issue.

Thanks for the fix, now seems to work and also tests are OK.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → made their first commit to this issue’s fork.

gxleano → credited alvar0hurtad0 → .

alvar0hurtad0 → created an issue.

Thanks for your effort

alvar0hurtad0 → created an issue.

Problem/ motivation

The responsibility of the iconify service should not include writing to the file system, although it should use a caching system.

Proposed solution

* Create a new service for the cache
* Inject the cache service to the iconify service
* Create proper testing for the new service and clean the ones in the iconify service.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → created an issue.

alvar0hurtad0 → created an issue.

Greetings to all our followers :)

alvar0hurtad0 → created an issue.

Thanks Joachim, I think it's now fixed.

A partir del 20 de junio que terminen los enanos con el cole y las extraescolares, sin problemas.

alvar0hurtad0 → created an issue.

Si, sin problema.

ostia!!

Thanks a lot Broke, for me is a great feeling to know the module is useful for someone else.

I'd be great to find a more meaningful module name:

https://git.drupalcode.org/project/url_text/-/blob/1.x/url_text.info.yml...

name: URL

Same here:
https://git.drupalcode.org/project/url_text/-/blob/1.x/src/Plugin/Field/...

 *   label = @Translation("URL"),

The mailto format doesn't seem to be correct:
https://en.wikipedia.org/wiki/Mailto
https://git.drupalcode.org/project/url_text/-/blob/1.x/src/Plugin/Field/...

      'mailto' => 'mailto://',

I've tested the module and honestly I don't see any real difference with the plain text fields:

I'm reviewing

There's a full release of the module:
https://www.drupal.org/project/autotagger →

Thanks David

True, thanks for the heads-up.

Now I understand the issue, and I think is fixed.

https://git.drupalcode.org/project/autotagger/-/commit/bbb0d3a47222b42f5...

I think this patch applies in an old version of the module before the stable release.
Could you check if the error still exists with current release?
I could not reproduce.

removing the assigned field.

Thanks @brooke_heaton, I've submited a commit that should fix this issue.

I'll create a new release including also #3424520

yes, you'll have attribution.

let me try :)

Hello Brooke,

Thank you very much for the MR and raising the issue. Looks good to me but it'll be great if you could use a ternary operation in order to avoid an extra indentation level.

it's something we're trying to do in the whole codebase and it'll make it more homogeneous.

Thank you very much.

alvar0hurtad0 → made their first commit to this issue’s fork.

I see this as a security issue:

https://git.drupalcode.org/project/sharepoint_connector/-/blob/1.0.x/src...

  public function access(Route $route) {
    return ($this->moduleHandler->moduleExists('webform')) ? AccessResult::allowed() : AccessResult::forbidden();
  }

In my eyes we should compliment with a permission or provide a neutral result in order to allow other existing permissions to return a forbidden if the user should not access to the route. Also the webform module is a dependency in in the info.yml file, so it seems like this access check is always true.

also includes simplifications of the module and fixes to some CS problems.

Thanks.

Looks good.

alvar0hurtad0 → created an issue.

Some screenshots are added and the roadmap.
I think now is way more clear how to use the module.

Some images to make things easier

alvar0hurtad0 → created an issue.

alvar0hurtad0 → created an issue.