$expected parameter in test is badly named

Created on 7 February 2024, 11 months ago

Updated 5 June 2024, 7 months ago

The param says:

   * @param array $expected
   *   The expected terms.

But it's not the EXACT list of expected terms, because it's asserted like this:

    foreach ($expected as $term) {
      $this->assertContains($term, $termsInNode);
    }

In other words, if I omit something from this parameter, and it's in the actual value, the test will pass.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Documentation

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @joachim
Comment 7 months ago →
System Message

alvar0hurtad0 → committed 4935a772 on 1.0.x
Issue #3419826: $expected parameter in test is badly named
Status changed to Fixed 7 months ago11:00am 22 May 2024
Comment 7 months ago →
🇪🇸Spain alvar0hurtad0 Cáceres
Thanks Joachim, I think it's now fixed.
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024