$expected parameter in test is badly named

Created on 7 February 2024, 5 months ago
Updated 5 June 2024, 25 days ago

Problem/Motivation

The param says:

   * @param array $expected
   *   The expected terms.

But it's not the EXACT list of expected terms, because it's asserted like this:

    foreach ($expected as $term) {
      $this->assertContains($term, $termsInNode);
    }

In other words, if I omit something from this parameter, and it's in the actual value, the test will pass.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Documentation

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024