- Status changed to Needs work
over 1 year ago 2:06am 2 May 2023 - 🇵ðŸ‡Philippines paraderojether
I reviewed MR!5, and after applying the MR, I'm getting this new error shown below:
FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/button_field/config/schema/button_field.schema.yml
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
59 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/button_field/button_field.module
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
15 | WARNING | [ ] Unused variable $table_name.
16 | WARNING | [ ] Unused variable $id.
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/button_field/README.txt
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
10 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------------------------------FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/button_field/src/Plugin/Field/FieldFormatter/ButtonFieldBase.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
68 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------Time: 452ms; Memory: 10MB
Please check.
Thank You. - First commit to issue fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22last update
over 1 year ago Waiting for branch to pass - 🇮🇹Italy apaderno Brescia, 🇮🇹
As a side note, the issue summary shows the report for the Drupal ruleset. It cannot be compared to a report that uses also the DrupalPractice ruleset.
- First commit to issue fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22last update
about 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22last update
about 1 year ago Waiting for branch to pass - Status changed to Needs review
about 1 year ago 11:57am 14 November 2023 - 🇷🇺Russia zniki.ru
MR #5 is ready for review, please take closer look at
src/Plugin/Field/FieldFormatter/ButtonFieldBase.php. - First commit to issue fork.
- 🇮🇳India manish-31
I have rebased the MR and resolved MR conflicts.
Fixed another issue detected by PHPCS after rebasing the MR. Needs review thanks!
- Status changed to Needs work
8 months ago 7:10am 25 April 2024 - 🇵ðŸ‡Philippines paraderojether
Hi
I reviewed MR!5, and confirmed it is applied however I got this warning
warning: 1 line adds whitespace errors.while applying the patch.jetherparadero@PrometSources-MacBook-Pro-3 button_field % curl https://git.drupalcode.org/project/button_field/-/merge_requests/5.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 22752 0 22752 0 0 49076 0 --:--:-- --:--:-- --:--:-- 49785 <stdin>:11: trailing whitespace. - Button field reload action has been removed. Use the Rules Core Checking patch README.txt... Checking patch button_field.module... Checking patch src/Plugin/Field/FieldFormatter/ButtonFieldBase.php... Checking patch src/Plugin/Field/FieldFormatter/ButtonFieldHtml.php... Checking patch src/Plugin/Field/FieldFormatter/ButtonFieldImage.php... Checking patch src/Plugin/Field/FieldType/ButtonField.php... Checking patch src/Plugin/Field/FieldWidget/ButtonFieldBase.php... Checking patch src/Plugin/Field/FieldWidget/ButtonFieldHtml.php... Checking patch src/Plugin/Field/FieldWidget/ButtonFieldImage.php... Checking patch src/Plugin/migrate/field/d7/ButtonField.php... Checking patch tests/src/TestSite/ButtonFieldInstallTestScript.php... Applied patch README.txt cleanly. Applied patch button_field.module cleanly. Applied patch src/Plugin/Field/FieldFormatter/ButtonFieldBase.php cleanly. Applied patch src/Plugin/Field/FieldFormatter/ButtonFieldHtml.php cleanly. Applied patch src/Plugin/Field/FieldFormatter/ButtonFieldImage.php cleanly. Applied patch src/Plugin/Field/FieldType/ButtonField.php cleanly. Applied patch src/Plugin/Field/FieldWidget/ButtonFieldBase.php cleanly. Applied patch src/Plugin/Field/FieldWidget/ButtonFieldHtml.php cleanly. Applied patch src/Plugin/Field/FieldWidget/ButtonFieldImage.php cleanly. Applied patch src/Plugin/migrate/field/d7/ButtonField.php cleanly. Applied patch tests/src/TestSite/ButtonFieldInstallTestScript.php cleanly. warning: 1 line adds whitespace errors. jetherparadero@PrometSources-MacBook-Pro-3 button_field % cd .. jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml button_field jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig button_field jetherparadero@PrometSources-MacBook-Pro-3 contrib %Please check and advise for the warning after applying patch.
Thank you. - 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3331941-drupal-coding-standard to hidden.
- Status changed to Needs review
8 months ago 10:15am 1 May 2024 - Status changed to Needs work
5 months ago 11:20am 7 August 2024 - 🇮🇳India atul_ghate
I have reviewed and applied MR5 cleanly, and fixed most of the PHPCS issues. However, there are still some remaining issues, so marking it as "needs work."
- Status changed to Needs review
5 months ago 2:29pm 8 August 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- 🇮🇳India atul_ghate
I have reviewed and applied patch cleanly, it resolved the all phpcs issue. RTBC+