Fix the issues reported by phpcs

Fixed remaining PHPCS error

The last submitted patch, 11: 3331519-11.patch, failed testing. View results →

Please review this patch.

Thanks

The last submitted patch, 17: 3331519-17.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Revised patch #18 and fixed remaining issues

FILE: pagerer/pagerer_example/src/Controller/PagererExampleController.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
 20 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 54 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 71 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 83 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------


FILE: pagerer/pagerer.module
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
 108 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 178 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: pagerer/src/Form/PagererConfigForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Pager\PagerManagerInterface.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Entity/PagererPreset.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 84 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: pagerer/src/PagererPresetListBuilder.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityHandlerInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Plugin/pagerer/PagererStyleBase.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Plugin/pagerer/Multipane.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\pagerer\Entity\PagererPreset.
 73 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 74 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 75 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 89 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/PagererManager.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Pager\PagerManager.
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

Time: 473ms; Memory: 18MB

The last submitted patch, 19: 3331519-19.patch, failed testing. View results →

Thanks @adwivedi008 for you contribution,
Please double check that you remove trailing whitespaces, there are tons of them in the patch you provided #19.
I added StringTranslationTrait in test file, but looks like tests are failed, not sure that we need to fix them inside this issue.

I tried to run tests on localhost, but get error.

Undefined array key "views"
 /var/www/html/core/modules/views/tests/src/FunctionalJavascript/PaginationAJAXTest.php:80
 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
 

Undefined array key "views"
 /var/www/html/core/modules/views/tests/src/FunctionalJavascript/PaginationAJAXTest.php:164
 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Made review of patch from #21.
Here is updated patch.

Create MR to use gitlab ci.
Hide all patch files.

Update Issue summary, update phpcs violations.

zniki.ru → closed merge request !20

I create separate MR to test fixes for eslint, phpstan, stylelint.
https://git.drupalcode.org/issue/pagerer-3331519/-/merge_requests/2

Not all phpstan issues is fixed so far:

php vendor/bin/phpstan analyze modules/contrib/pagerer --configuration=modules/contrib/pagerer/phpstan.neon --generate-baseline

Result:

 ------ ------------------------------------------------------------------------------------------------ 
  Line   src/Plugin/pagerer/PagererStyleBase.php                                                         
 ------ ------------------------------------------------------------------------------------------------ 
  430    Call to an undefined method Drupal\pagerer\Plugin\pagerer\PagererStyleBase::buildPagerItems().  
 ------ ------------------------------------------------------------------------------------------------ 

 ------ ----------------------------------------------- 
  Line   tests/src/Functional/CorePagerReplaceTest.php  
 ------ ----------------------------------------------- 
  36     Missing call to parent::setUp() method.        
 ------ ----------------------------------------------- 

Not sure how to fix it.

Thanks for working on this. I agree, let's only do PHPCS fixes in this issue.

I just added more configuration for GitlabCI testing - phpstan.neon and phpcs.xml.dist. PHPCS is now configured to skip README.md, so I would not touch that here.

Also, I dropped all DrupalCI configration and testing.

Thanks for the feedback I create separate issue #3402666 📌 Fix PHPStan, eslint, stylelint violations Fixed to work on PHPStan, eslint, stylelint.

@mondrake do you want to remove changes in README.md file.
We already made some changes in this file and I think we can keep it even if it will be excluded from phpcs check in the future.
What do you think?

I don't see other things that needs to be done for this issue, there is no phpcs violations left. Please let me know if I miss something?

Thanks! I made some comments inline the MR, that need work. For README.md, OK, but please let's make sure that if we make changes because og the 80 chars limit per line, each changed line gets as close as possible to 80 chars.

Thanks for feedback.

I changed my mind about README.md, I think we can keep it without changes.
I updated MR, and removed changes for README.md file, and left only fix.

Very close! Thanks for your work.

Thanks for a review. I made suggested changes. MR is ready for review.

This is first time I see this readonly property, I will not argue, fixed.

Drupal core is slowly introducing this. See for example #1014086-368: Stampedes and cold cache performance issues with css/js aggregation → .

Credit.

Merged. Thank you!!

Automatically closed - issue fixed for 2 weeks with no activity.