Contrib.social

Fix PHPStan, eslint, stylelint violations

Open on Drupal.org →
Created on 19 November 2023, about 1 year ago
Updated 22 November 2023, about 1 year ago

Problem/Motivation

After enabling Gitlab CI "validate" pipeline have some warning for PHPStan, eslint, stylelint check.
PHPCS fix happens in #3331519 📌 Fix the issues reported by phpcs Fixed .

Steps to reproduce

PHPStan

php vendor/bin/phpstan analyze modules/contrib/pagerer --configuration=modules/contrib/pagerer/phpstan.neon

eslint

yarn --silient --cwd ./core stylelint --formatter verbose --config ./.stylelintrc.json ../modules/contrib/pagerer/**/*.css --color

Proposed resolution

Fix or mute all violations.
Pipeline "validate" need to be green/pass.
Skip phpcs check, until it will be fixed.

Remaining tasks

Fix violations:

$ php vendor/bin/phpstan analyze /modules/custom/pagerer --configuration=modules/pagerer/phpstan.neon
 ------ -------------------------------------------------------------------- 
  Line   src/Plugin/pagerer/PagererStyleBase.php                             
 ------ -------------------------------------------------------------------- 
  430    Call to an undefined method                                         
         Drupal\pagerer\Plugin\pagerer\PagererStyleBase::buildPagerItems().  
 ------ -------------------------------------------------------------------- 
 ------ ----------------------------------------------- 
  Line   tests/src/Functional/CorePagerReplaceTest.php  
 ------ ----------------------------------------------- 
  36     Missing call to parent::setUp() method.        
 ------ -----------------------------------------------
📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇷🇺Russia zniki.ru

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024