Fix PHPStan L2 error in traits

+++ b/core/modules/rest/tests/src/Functional/BasicAuthResourceTestTrait.php
@@ -23,7 +23,7 @@ trait BasicAuthResourceTestTrait {
-        'Authorization' => 'Basic ' . base64_encode($this->account->name->value . ':' . $this->account->passRaw),
+        'Authorization' => 'Basic ' . base64_encode($this->account->getAccountName()->value . ':' . $this->account->passRaw),

I think this is the cause of all the broken tests. getAccountName returns a string, so value isn't needed.

The patch also doesn't apply to 10.1.x anymore, fixed the issues but couldn't get the baseline to regenerate properly. I was getting a lot of new warnings added to the baseline

Self addressed the feedback in #14 and regenerated the baseline. Lets see how the tests go.

Believe I tested this one write

I applied the patch
Changed the level to 2
Staged everything
./core/scripts/dev/commit-code-check.sh --cached
Got no errors.

Let me know if I missed a step for these level 2 stuff.

Should this be postponed on 📌 Fix PHPStan L1 errors "Call to method getDefinitions()/getSortedDefinitions() on an unknown class Drupal\Core\Plugin\CategorizingPluginManagerTrait." Needs work , or should that part of the change here be removed, given it interferes with the fix there?

Oh good call. Yeah I think we should remove it from this issue. Thats only one part of this patch, so we can just remove it and regenerate the baseline