- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks for the issue and patch. For people to know it needs review, you should change to the "Needs review" status.
1. The "TODO" should be removed.
2.
"Request you to upload files."
should be reworded to be more clear and use single quotes, e.g.'No media files have been provided.'
- Status changed to Needs review
almost 2 years ago 10:19am 5 April 2023 - 🇮🇳India mrinalini9 New Delhi
Rerolled patch #2 as it doesn't apply and addressed feedback from #4, please review it.
Thanks!
- Assigned to shivam_tiwari
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 11:03pm 10 April 2023 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks @mrinalini9. I wasn't clear enough in #4. The entire "TODO" comment should have been removed.
+++ b/src/Form/MediaBulkUploadForm.php @@ -598,4 +598,22 @@ class MediaBulkUploadForm extends FormBase { + parent::validateForm($form, $form_state); // Change the autogenerated stub
Entire comment needs to be removed.
- Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
I'm going to update this and get it merged.
-
Kristen Pol →
committed bf56cccb on 3.0.x authored by
mrinalini9 →
Issue #3324771 by mrinalini9, sudesh.solaskar, Kristen Pol: Validation...
-
Kristen Pol →
committed bf56cccb on 3.0.x authored by
mrinalini9 →
- Issue was unassigned.
- Status changed to Fixed
almost 2 years ago 4:37am 12 April 2023 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
I reviewed more carefully and tested it and updated the code so it only fires if dropzonejs is used.
Thanks, everyone!
-
Kristen Pol →
committed 9f052509 on 3.0.x authored by
mrinalini9 →
Issue #3324771 by mrinalini9, sudesh.solaskar, Kristen Pol: Validation...
-
Kristen Pol →
committed 9f052509 on 3.0.x authored by
mrinalini9 →
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Actually, the code wasn't correct so I update to be more like 📌 Add form validation to inform other module to valid the new uploaded files Fixed which will be merged soon.
Automatically closed - issue fixed for 2 weeks with no activity.