- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Nice work! There are some minor formatting issues (isn't using Drupal coding standards) but I might clean these up myself.
@codepress Adding issue credit for you since you provided a screenshot of the result but, in the future, please read this:
https://www.kristen.org/content/my-drupal-issue-queue-rtbc-cheat-sheet
1) You should only move to RTBC if you or someone else has reviewed the code and it's also been manually tested (and other things for core issues and some contributed projects... see the blog post).
2) You should add notes as to how you manually tested.
Assigning to myself to try to get this into the next release.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 11:58pm 10 April 2023 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I created a patch with the formatting changes and some comment rewording and some simplification. Someone can update the MR with these changes if they want but it's not necessary. I added a raw diff between the MR and the updated patch rather than a proper interdiff.
This code needs to be reviewed to make sure I didn't mess anything up.
-
Kristen Pol β
committed 05a25e65 on 3.0.x
Issue #3291228 by Mingsong, Kristen Pol, codepress: Add form validation...
-
Kristen Pol β
committed 05a25e65 on 3.0.x
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I tested with a custom validation function and made some minor tweaks. I had trouble setting up clamav in DrupalPod so I'm waiting to hear back on that. This should be fixed so changing status. We can reopen if it's not working with clamav.
Thanks, everyone!
- Status changed to Fixed
almost 2 years ago 7:44am 26 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.