- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 12:53pm 30 March 2023 Hi guys, any updates here?
Can somebody check my changes?
Thank you in advance- 🇵🇹Portugal jcnventura
This is complex enough that others should mark it as RTBC..
- Status changed to Needs work
11 months ago 9:20am 14 May 2024 - Status changed to Needs review
7 months ago 1:48pm 18 September 2024 @anybody I've resolved the merge error, so MR is mergeable now
- Status changed to Needs work
7 months ago 3:45pm 18 September 2024 - 🇩🇪Germany Anybody Porta Westfalica
Thanks! I guess what's finally needed now, are tests.
- 🇩🇪Germany Anybody Porta Westfalica
@grevil: Could you finally review this by time? Thanks!
- Assigned to Grevil
- Status changed to Needs review
2 days ago 1:54pm 15 April 2025 - 🇩🇪Germany yannickoo Berlin
Hey! First of all thanks for the contribution!
I'm currently reviewing the MR and I think this modules should provide attribute for the menu links (which covers the
<li>
and the<a>
elements. I don't see big reasons to allow site managers to add attributes to the<ul>
element itself and those could be rather added via a dedicatedmenu.html.twig
file.What do you think?