Comment form gives deprecated warnings on PHP 8.1 when comment is empty

The same issue on 10.1 version. When you click on preview of empty comment also.

Akhil Babu → changed the visibility of the branch 11.x to hidden.

If we use the condition ff ($comment->hasField('comment_body') && !$comment->comment_body->isEmpty()) , then

        if (empty($comment_text)) {
          $comment->setSubject(NULL);
        }
        else {
          $comment->setSubject(Unicode::truncate(trim(Html::decodeEntities(strip_tags((string) $comment_text))), 29, TRUE, TRUE));
        }

part is no longer needed.

Changed the logic as per review comments in 2995 and raised a new MR against 11.x branch

Verified and tested patch merge request !5871 on Drupal version- 11.0-dev & PHP version- 8.1.26. The patch was applied successfully and looks good to me.

Testing Steps:

1. Enable Comments for the content type.
2. Go to the content node & add a blank comment to reproduce. Shared before results
3. Download this patch and Apply.
4. Reverify this by adding a blank comment on the content node.

Testing Results:
Now the required field is highlighted & a validation message is displayed.

Moving this ticket to RTBC.

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions.

I did find one comment not wrapped correctly, see the MR. Setting to Needs work for that.

Thanks!

Thanks for thr reviewing.
I have udated the code comment and modified the test in MR 5871 (11.X branch).

Hi,
I verified and tested patch MR!5871 on Drupal version- 11.0-dev.
The patch was applied successfully.

Testing Steps:

1. Enable Comments for the content type.
2. Comment Field is not required-> to the content node & add a blank comment and Save.
3. Comment Field is Required-> to the content node & add a blank comment and Save.
4. Reproduce the issue. and shared before results
5. Download this patch and Apply.
6. Reverify this by adding a blank comment on the content node with the required field and not required field .

Testing Results:

1. For Required field -> Now the required field is highlighted & a validation message is displayed.
2. For not required -> comment saved with the "No Subject" without any error message

Screenshots are attached for reference
Re- comment field required
NR- comment field not required

Feedback for wrapping text by @quietone appers to have been addressed.

Left a comment on the MR.

Updated the test. Thanks!

Feedback appears to be addressed.

larowlan → closed merge request !2995

larowlan → credited alexpott → .

Committed to 11.x and backported to 10.2.x

Thanks

larowlan → closed merge request !5871

Automatically closed - issue fixed for 2 weeks with no activity.