Coding Standard phpcs

Fixed all Coding standard PHPCS issue

The last submitted patch, 4: 3322809-4.patch, failed testing. View results →

The tests failed, so the correct status is Needs work.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.

Fixed all Coding standard PHPCS issues

Hello @nikhilmahala11 tested the patch you provided, it still have few errors.

../vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/field_permissions

FILE: ...tions/MAMP/htdocs/drupal_contrib/drupal-9.5-dev/web/modules/contrib/field_permissions/CHANGELOG.md
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------
33 | WARNING | Line exceeds 80 characters; contains 93 characters
58 | WARNING | Line exceeds 80 characters; contains 140 characters
--------------------------------------------------------------------------------------------------------

FILE: ...tdocs/drupal_contrib/drupal-9.5-dev/web/modules/contrib/field_permissions/field_permissions.module
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
145 | ERROR | All functions defined in a module file must be prefixed with the module's name, found
| | "field_permission_field_config_edit_form_submit" but expected
| | "field_permissions_field_permission_field_config_edit_form_submit"
--------------------------------------------------------------------------------------------------------

Time: 305ms; Memory: 12MB

Verified the patch #17 on Drupal version 10.1.x and Field Permission version 8.x-1.x. The patch applied cleanly and except the following errors, all other coding standard issues are fixed.

FILE: .../contrib/field_permissions/field_permissions.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------
 151 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "field_permission_field_config_edit_form_submit" but
     |       | expected "field_permissions_field_permission_field_config_edit_form_submit"
--------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: .../contrib/field_permissions/src/Plugin/FieldPermissionType/Manager.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
 56 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------

Time: 796ms; Memory: 12MB

Hi,
Addressed the error and warning mentioned in #18.
Please Review.
Thankyou!!

Fixed few remaining CS issues, since the phpcs job succeeds on CI, I set the status to RTBC.

apaderno → changed the visibility of the branch coding_standard to hidden.

apaderno → changed the visibility of the branch 3322809-coding-standard-phpcs to hidden.

The MR still needs to be reviewed, even if GitLab CI says there are no PHP_CodeSniffer warnings/errors.

Hi

I applied the updated MR !24 and I can still see PHPCS issues

➜  field_permissions git:(a5aee30) curl https://git.drupalcode.org/project/field_permissions/-/merge_requests/24.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 19437    0 19437    0     0  33991      0 --:--:-- --:--:-- --:--:-- 34462
patching file CHANGELOG.md
patching file field_permissions.info.yml
patching file field_permissions.module
patching file 'src/Controller/FieldPermissionsController.php'
patching file 'src/FieldPermissionsService.php'
patching file 'src/Plugin/migrate/process/FieldPermissionSettings.php'
patching file 'tests/modules/field_permissions_test/src/Plugin/FieldPermissionType/TestAccess.php'
patching file 'tests/src/Unit/FieldPermissionsServiceTest.php'
patching file 'tests/src/Unit/Plugin/FieldPermissionType/CustomAccessTest.php'
patching file 'tests/src/Unit/Plugin/FieldPermissionType/PrivateAccessTest.php'
➜  field_permissions git:(a5aee30) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml field_permissions 

FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/field_permissions/CHANGELOG.md
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------
 15 | WARNING | Line exceeds 80 characters; contains 84 characters
 50 | WARNING | Line exceeds 80 characters; contains 88 characters
-------------------------------------------------------------------------------------------------------


FILE: ...-subing/Projects/d9/d9-local/web/modules/contrib/field_permissions/tests/src/Unit/FieldPermissionsServiceTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 144 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over
     |       | multiple lines
-----------------------------------------------------------------------------------------------------------------------


FILE: ...g/Projects/d9/d9-local/web/modules/contrib/field_permissions/tests/src/Functional/FieldPermissionsCommentTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 194 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over
     |       | multiple lines
-----------------------------------------------------------------------------------------------------------------------


FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/field_permissions/tests/src/Functional/FieldPermissionsNodeTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------
  74 | ERROR   | The array declaration extends to column 98 (the limit is 80). The array content should be split up
     |         | over multiple lines
  91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 212 | ERROR   | The array declaration extends to column 104 (the limit is 80). The array content should be split up
     |         | over multiple lines
 238 | ERROR   | The array declaration extends to column 94 (the limit is 80). The array content should be split up
     |         | over multiple lines
-----------------------------------------------------------------------------------------------------------------------


FILE: ...bing-subing/Projects/d9/d9-local/web/modules/contrib/field_permissions/src/Plugin/FieldPermissionType/Manager.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 56 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------


FILE: ...g-subing/Projects/d9/d9-local/web/modules/contrib/field_permissions/src/Controller/FieldPermissionsController.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 100 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over
     |       | multiple lines
-----------------------------------------------------------------------------------------------------------------------

Time: 877ms; Memory: 12MB

retaining the status to needs review so that others can give their feedback

GitLab CI does not report any PHP_CodeSniffer issues.

I updated the description with the current issues reported by phpcs.

bluegeek9 → changed the visibility of the branch 8.x-1.x to hidden.

bluegeek9 → changed the visibility of the branch 3322809-8.x-1.x to hidden.

All tests including phpcs are passing.