- ๐ฎ๐ณIndia Nupur Badola
Issue is found in the patch.
git.drupalcode.org_project_field_delimiter_-_merge_requests_1.diff.txt:16: trailing whitespace. git.drupalcode.org_project_field_delimiter_-_merge_requests_1.diff.txt:21: trailing whitespace. warning: 2 lines add whitespace errors.
- Assigned to sourabhjain
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 3:58pm 6 June 2023 - ๐ต๐ญPhilippines clarkssquared
Hi
I applied the updated MR !1 and confirmed that the patch applies cleanly and replaced the README.txt to README.md, however the README.md format did not follow README.md Drupal Format โ , hence I will move this to needs work for formatting issue.
Please also look at the screenshot attached
Thank you
- Assigned to nitin_lama
- Status changed to Needs review
over 1 year ago 1:13pm 8 June 2023 - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 2:17pm 8 June 2023 - ๐ต๐ญPhilippines clarkssquared
Hi nitin_lama
I applied the updated MR !1 to my local and confirmed that it fixed the formatting issue of the README.md file, however, according to the Drupal format for README.md, the Requirements and Configurations sections are missing from the README.md file which are required. README.md Drupal Format โ for convenience below are the summary of sections that is mentioned in Drupal.org
README sections
Drupal recommends the following README sections:Project name and introduction (required)
Table of contents (optional)
Requirements (required)
Recommended modules (optional)
Installation (required, unless a separate INSTALL.md is provided)
Configuration (required)
Troubleshooting & FAQ (optional)
Maintainers (optional)Please look at the screenshot attached for your reference.
Thank you
- ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
12 months ago 6:41am 29 November 2023 - Status changed to RTBC
12 months ago 1:10am 30 November 2023 - ๐ต๐ญPhilippines clarkssquared
Hi
I applied the MR !1 again after the commit #13 and I confirmed that it creates a README.md and according to Drupal's README template, I wont upload any screenshots but instead this is the README.md content that the updated MR !1 creates.
# Field Delimiter (Multi Value Field Formatter) Field Delimiter provides an additional setting for field formatters, allowing multi-value fields to be displayed with a delimiter between the values. For a full description of the module, visit the [project page](https://www.drupal.org/project/field_delimiter). Submit bug reports and feature suggestions, or track changes in the [issue queue](https://www.drupal.org/project/issues/field_delimiter). ## Table of contents - Requirements - Installation - Configuration - Dependencies - Maintainers ## Requirements This module requires no modules outside of Drupal core. ## Installation Install as you would normally install a contributed Drupal module. For further information, see [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules). ## Configuration The module has no menu or modifiable settings. There is no configuration. ## Dependencies The Drupal 7 version depends on [Field formatter settings](https://www.drupal.org/project/field_formatter_settings) API module. ## Maintainers - andrewmacpherson - [andrewmacpherson](https://www.drupal.org/u/andrewmacpherson) - purushotam.rai - [purushotam.rai](https://www.drupal.org/u/purushotamrai)