- 🇨🇦Canada RobLoach Earth
Thanks so much, this is coming along. Mind recreating this for the 3.0.x branch? Thanks so much. Also, I think it's following the standard README.md template? https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
- Assigned to ressa
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 5:02pm 24 October 2023 - 🇩🇰Denmark ressa Copenhagen
Sure @RobLoach, it looked like adding a few maintainers was the only difference? And yes, the standard README.md template has been followed.
- First commit to issue fork.
- Status changed to Needs work
11 months ago 12:57am 20 December 2023 - 🇵🇭Philippines kenyoOwen
Hi thakurnishant_06
I reviewed your changes and noticed that in "Project page" text missing a comma
For a full description of the module visit the
it should beFor a full description of the module, visit the
Thank you
- Status changed to Needs review
11 months ago 4:15am 20 December 2023 - Status changed to Needs work
11 months ago 8:05am 20 December 2023 - 🇮🇳India Nupur Badola
Reviewed MR!6, the patch is not cleanly applied.
1) 6.diff.txt:10: trailing whitespace. relatively simple: `[view:name=display=args]`. The parameters are: view name, 6.diff.txt:11: trailing whitespace. view display id, view arguments. For example `[view:tracker=page=1]` says, 6.diff.txt:12: trailing whitespace. embed a view named "tracker", use the "page" display, and supply the argument 6.diff.txt:13: trailing whitespace. "1". The display and args parameters can be omitted. If the display is left 6.diff.txt:14: trailing whitespace. empty, the view's default display is used. Multiple arguments are separated warning: squelched 3 whitespace errors warning: 8 lines add whitespace errors. 2) In the configuration section, - is not required as this is a list.
- Status changed to Needs review
11 months ago 9:36am 20 December 2023 - Status changed to Needs work
11 months ago 11:53am 27 December 2023 - 🇮🇳India Nupur Badola
Reviewed MR!6, the patch is not cleanly applied.
1) 6.diff.txt:33: trailing whitespace.
6.diff.txt:37: trailing whitespace.
- How to find a display id
warning: 2 lines add whitespace errors. - Status changed to Needs review
11 months ago 11:25am 28 December 2023 - Status changed to Needs work
11 months ago 11:21pm 28 December 2023 - 🇵🇭Philippines kenyoOwen
Hi thakurnishant_06
I reviewed your changes in MR!6 and noticed that maintainers missing (-) in
- Paulo Henrique Starling [paulocs](https://www.drupal.org/u/paulocs) - Michael Samuelson [mlsamuelson](https://www.drupal.org/u/mlsamuelson) - Artem Dmitriiev [a.dmitriiev](https://www.drupal.org/u/admitriiev)
it should be
andrew morton - [drewish](https://www.drupal.org/u/drewish)
Thank you.
- Status changed to Needs review
11 months ago 11:31am 29 December 2023 -
RobLoach →
committed c3a2f577 on 2.0.x authored by
ressa →
Issue #3319638 by arti_parmar: Replace README.txt with README.md
-
RobLoach →
committed c3a2f577 on 2.0.x authored by
ressa →
- Status changed to Fixed
11 months ago 6:49am 12 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.