Update @todos for closed issue https://www.drupal.org/node/1928868

As far as I understand it, we should simply remove the comment function, but it is not very clear to me why this is still here a few years ago referencing an issue that has already been integrated.

Maybe @xjm could clarify, because she was the one who added it.

gxleano → closed merge request !3407

Maybe @xjm could clarify, because she was the one who added it.

Uh, nope, I was not at all. I just happened to commit the most recent change to this line, and all the issue I committed did was update the URL to avoid a redirect. So don't ask xjm, ask git:

commit 088f8b357a5b233e5b06061304df4d6bf259d31c
Author: xjm <xjm@65776.no-reply.drupal.org>
Date:   Sun May 24 15:08:46 2015 -0500

    Issue #2491155 by mikeburrelljr, Mac_Weber, opdavies: Update drupal.org and kernel.org URLs in core modules (Follow-up to 2489912)

diff --git a/core/lib/Drupal/Core/TypedData/DataDefinition.php b/core/lib/Drupal/Core/TypedData/DataDefinition.php
--- a/core/lib/Drupal/Core/TypedData/DataDefinition.php
+++ b/core/lib/Drupal/Core/TypedData/DataDefinition.php
@@ -298,1 +298,1 @@
-   * @todo: Remove in https://drupal.org/node/1928868.
+   * @todo: Remove in https://www.drupal.org/node/1928868.

commit e8c263c4a5956d278be8a61c836b2c6566416da6
Author: Nathaniel Catchpole <catch@35733.no-reply.drupal.org>
Date:   Fri Dec 6 10:56:29 2013 +0000

    Issue #2112239 by amateescu: Convert base field and property definitions.

diff --git a/core/lib/Drupal/Core/TypedData/DataDefinition.php b/core/lib/Drupal/Core/TypedData/DataDefinition.php
--- a/core/lib/Drupal/Core/TypedData/DataDefinition.php
+++ b/core/lib/Drupal/Core/TypedData/DataDefinition.php
@@ -281,1 +306,1 @@
-   * @todo: Remove once https://drupal.org/node/2112239 is in.
+   * @todo: Remove in https://drupal.org/node/1928868.

commit 9bcaedec1558a70a0967581babc8ce429c40687b
Author: webchick <webchick@24967.no-reply.drupal.org>
Date:   Wed Nov 27 13:54:33 2013 -0800

    Issue #2047229 by fago, smiletrl, Berdir, effulgentsia, amateescu: Make use of classes for entity field and data definitions.

diff --git a/core/lib/Drupal/Core/TypedData/DataDefinition.php b/core/lib/Drupal/Core/TypedData/DataDefinition.php
--- /dev/null
+++ b/core/lib/Drupal/Core/TypedData/DataDefinition.php
@@ -0,0 +281,1 @@
+   * @todo: Remove once https://drupal.org/node/2112239 is in.

So, the answer to whether this change is correct or not lies somewhere in #2047229: Make use of classes for entity field and data definitions → , which is an issue I never even commented on other than to fix someone else's crosspost about the issue priority.

Fixing attribution.

Thanks to clarify @xjm! :)

I will take a look into #2047229.

What was decided in #11?

I would need to take a look on https://www.drupal.org/project/drupal/issues/2047229 →

I don't think this needs to be postponed; nothing is blocking it. Usually we use PMNMI when someone has information that is not available in the codebase or issue queue, but in this case, the info is (theoretically) in the past issue.

We just perhaps should have an IS update based on the linked original issue.

Working at the moment to get this branch working for D11

The original branch was created under D10.x and the DrupalPod install failed to run (Composer dependencies).

This branch has the update to D11.x (command line '$ git rebase 11.x ' ).

Now possible to review properly.

I'm triaging RTBC issues → . I read the IS and the comments.

The research that needs to be done (#11) has not been completed. I am removing the novice tag because that and have updated the issue summary with that task. I also searched core for 1928868 and there is a @todo referencing this issue that is not in the MR.

So, back to needs work for a bit of research.

Adding parent and adding this issue to the table in the issue summary of that issue.