D10 Compatibility (Config Partial Export)

Created on 24 September 2022, about 2 years ago
Updated 14 February 2024, 10 months ago

Problem/Motivation

Hello project maintainers,

This issue is to help make this module compatible with Drupal 10.

Patches will be added to this issue that remove Drupal 10 deprecated API uses.

Remaining tasks

------ ---------------------------------------------------------------------
Line config_partial_export.drush.inc
------ ---------------------------------------------------------------------
59 Function drush_print not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
61 Function drush_print not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
63 Function drush_print not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
74 Call to deprecated function drush_log().
94 Function drush_set_error not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
138 Call to deprecated function drush_log().
205 Function drush_print not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ ---------------------------------------------------------------------

------ ---------------------------------------------------------------------
Line src/Commands/ConfigPartialExportCommands.php
------ ---------------------------------------------------------------------
133 Function drush_set_error not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
318 Variable $selection_list might not be defined.
319 Variable $selection_list might not be defined.
330 Variable $selection_list might not be defined.
331 Variable $selection_list might not be defined.
357 Function drush_print not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ ---------------------------------------------------------------------

------ ---------------------------------------------------------------------
Line /config_partial_export.info.yml
------ ---------------------------------------------------------------------
0 Value of core_version_requirement: ^8 || ^9 is not compatible with the next major
version of Drupal core. See https://drupal.org/node/3070687..
------ ---------------------------------------------------------------------

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India Adarshsri786

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • 🇩🇪Germany Grevil

    Added final D10 compatibility changes using the upgrade_status module and PHPStan. I tested installing the module under Drupal 10 and exporting a few configs. Everything worked as expected! RTBC!

    The deprecation errors listed in this issue are not Drupal 10 related, but Drush related. I found an issue regarding this problem here: 🐛 Fix Drush Commands Closed: outdated . Although the provided patch there, can not fix the issue as many used functions simply do not exist any more, like for example "drush_print_table()", which got already removed in Drush 9.x! I will rework that issue, so we can continue there for the remaining deprecated / removed drush functions.

    Furthermore, there are multiple Drupal Coding Standard issues for this module. I created an issue to resolve them here: 🐛 Fix the issues reported by phpcs Needs work

    At last, the module page has a tiny (maybe also further) mistake:

    [...] (on the /admin/config/development/configuration URL path) tab. After enabling the module click on the Partial Export tab and select the files you want to export. [...]

    On the mentioned route, the Tab name is "Export" and then the Sub-Tab "Multiple items".

    PS: The changes for "StorageComparer" were necessary, as the constructor only needs two parameters, not three.

  • Status changed to RTBC almost 2 years ago
  • 🇩🇪Germany Grevil

    This module also has no tests, which can be quite dangerous!

    Created an issue for that issue as well: 📌 Create tests for basic module functionalities RTBC .

  • 🇩🇪Germany Anybody Porta Westfalica
  • 🇭🇺Hungary segi

    The Drupal 10 version is out. Still in dev(2.x) but it looks stable, but If you have time to test I appreciate it.

  • Status changed to Fixed almost 2 years ago
  • 🇭🇺Hungary segi

    I close this issue but I will review the other two issues(Coding standard and drush command).
    Please open a new issue if you still find problem in the new version(2.x)

  • Status changed to Fixed almost 2 years ago
  • 🇺🇸United States bob.hinrichs

    We look forward to a D10 release, thank you!

  • 🇬🇧United Kingdom siliconandincense

    Hi there, just gently asking if theres going to be a stable release for D10 soon?

    Thanks :)

  • 🇩🇪Germany Grevil

    @siliconandincense 2.0.0-alpha1 might be declared alpha and not stable, but apart from 1 commit (this issue's commit), it is identical to the "stable" 8.x-1.6. So might be worth checking that out!

  • 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Production build 0.71.5 2024