- πΊπΈUnited States chrisfromredfin Portland, Maine
Tried to review, but the rebase is really hairy on this one. If someone with better knowledge can get it rebased I can take another look.
- πͺπΈSpain fjgarlin
I tried to rebase but when compiling svelte it was complaining about unused selectors and styles, so that means I probably did something wrong. I'll leave the rebase to you guys as I don't want to mess anything up.
- Status changed to Needs review
over 1 year ago 8:34pm 24 February 2023 - πΊπΈUnited States chrisfromredfin Portland, Maine
According to testbot, the most recent passes, actually. Just trying to kick for a re-test.
- Status changed to Needs work
over 1 year ago 3:19pm 8 March 2023 - πΊπΈUnited States chrisfromredfin Portland, Maine
I think these test fails are legit.
- Status changed to Needs review
over 1 year ago 1:37pm 28 March 2023 - πΊπΈUnited States tim.plunkett Philadelphia
Marking back to NR since @Utkarsh_33 fixed the tests
- Status changed to RTBC
over 1 year ago 7:19pm 28 March 2023 - πΊπΈUnited States chrisfromredfin Portland, Maine
Tests are passing, I reviewed the code, I tested in DrupalPod and w/ VoiceOver on to check the aria-live region, and all seems to be behaving as expected!
- Status changed to Needs work
over 1 year ago 2:14pm 29 March 2023 - Status changed to Needs review
over 1 year ago 6:39am 30 March 2023 - Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - πΊπΈUnited States chrisfromredfin Portland, Maine
I can't push right now; I think because my SSH keys changed since I got push access to this old fork? Here's a patch where I've attempted a manual rebase. We'll see if I got the tests right.........
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 65 pass - @chrisfromredfin opened merge request.
- last update
over 1 year ago Custom Commands Failed - @chrisfromredfin opened merge request.
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 44 pass, 2 fail - last update
over 1 year ago 65 pass - last update
over 1 year ago 65 pass - Status changed to RTBC
over 1 year ago 1:29pm 8 June 2023 - πͺπΈSpain fjgarlin
Thanks for the rebasing!! I bet it wasn't an easy one.
Code looks good, mostly moving code between files and adding a useful label for screen readers.
Tested it with drupalpod as well and it all worked as expected.Marking it RTBC.
- last update
over 1 year ago 44 pass, 2 fail - πΊπΈUnited States tim.plunkett Philadelphia
The development status was showing up twice. Fixed that, hope I didn't break anything else
- last update
over 1 year ago 65 pass - πΊπΈUnited States chrisfromredfin Portland, Maine
Tests are passing! SHIP IT! QUICK!!
- last update
over 1 year ago 65 pass -
tim.plunkett β
committed bbf4465f on 1.0.x authored by
chrisfromredfin β
Issue #3310896 by Utkarsh_33, chrisfromredfin, tim.plunkett, bnjmnm,...
-
tim.plunkett β
committed bbf4465f on 1.0.x authored by
chrisfromredfin β
- Status changed to Fixed
over 1 year ago 3:33pm 14 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.