Remove AllowDynamicProperties attribute from JoinPluginBase

Created on 25 July 2022, almost 2 years ago

Updated 22 February 2023, over 1 year ago

Problem/Motivation

part of 🌱 [META] Get rid of #[\AllowDynamicProperties] attribute Active
Remove attribute added in #3299853: Apply #[\AllowDynamicProperties] attribute to base classes to make PHP 8.2 log size sane → for JoinPluginBase

The test to catch it is \Drupal\Tests\workspaces\Kernel\WorkspaceIntegrationTest::testWorkspaces()

Unsilenced deprecation notices (24)

  24x: Creation of dynamic property Drupal\views\Plugin\views\join\Standard::$workspace_adjusted is deprecated
    24x in WorkspaceIntegrationTest::testWorkspaces from Drupal\Tests\workspaces\Kernel

Proposed resolution

Use WeakMap inside of \Drupal\workspaces\ViewsQueryAlter as this pseudo-service is re-created for each query alter hook, see workspaces_views_query_alter()

Remaining tasks

- agree
- patch/review/commit

User interface changes

API changes

TBD

Data model changes

Release notes snippet

📌 Task

Status

Fixed

Version

10.1 ✨

Component

Views →

Last updated 30 minutes ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @tim.plunkett
🇬🇧United Kingdom @damiankloip
🇺🇸United States @xjm
🇳🇱Netherlands @Lendude

Created by

🇫🇷France andypost

Live updates comments and jobs are added and updated live.

PHP 8.2
The issue particularly affects sites running on PHP version 8.2.0 or later.

Needs Review Queue Initiative

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States smustgrave
Brought this up in #needs-review-queue-initiative channel and @andypost pointed out this doesn't need a change record.

So moving this one on.
Status changed to Fixed over 1 year ago9:55am 22 February 2023
Comment over 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed 85f7004 and pushed to 10.1.x. Thanks!

I think removing #[\AllowDynamicProperties] is not an API change. It means that if anything in contrib is doing something similar that can make the same change and PHP will issue deprecations telling them they need to do it.
Comment over 1 year ago →
System Message

alexpott → committed 88fab0ba on 10.1.x
Issue #3299859 by andypost, Anchal_gupta, longwave, alexpott: Remove...
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024