- 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- Status changed to Needs review
over 1 year ago 8:19am 19 June 2023 - Status changed to Needs work
4 months ago 7:04am 15 August 2024 - 🇵🇭Philippines cleavinjosh
Hi @samir_shukla,
Thank you for providing a patch.
I applied patch #3 and encountered an error.
➜ variants git:(1.0.x) curl https://www.drupal.org/files/issues/2022-09-02/variantpatch-3298537-3.patch | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 49618 100 49618 0 0 196k 0 --:--:-- --:--:-- --:--:-- 196k Checking patch README.md... error: while searching for: # Variants A generic variants system and a foundation for many types of entity variations. It uses an entities langcode column as a handle for variation references so that language managers can point to the right variation to display. # Location Variants `location_variants` aims to be a drop in replacement for core's `content_translation` module. Instead of just having translations for each language (think of translations as variations) you can have a variation for each location or group of locations and translations for each language those locations support. For instance, you could have a travel page and each country gets a different version of the page and each version of the page can have many translations. ## Installation `location_variants` requires a separate custom module that needs to subscribe to the `LocationEvent` and provide a hierarchy of Locations and the languages they support. e.g. ```yaml global: label: Global error: patch failed: README.md:1 error: README.md: patch does not apply Checking patch modules/basic_variant/README.md... Checking patch modules/basic_variant/basic_variant.info.yml... Checking patch modules/basic_variant/basic_variant.module... Checking patch modules/basic_variant/src/BasicVariations.php... Checking patch modules/basic_variant/src/EventSubscriber/VariationLanguageCodes.php... Checking patch modules/location_variant/location_variant.info.yml... error: while searching for: package: Variants core_version_requirement: ^9 || ^10 dependencies: - variants error: patch failed: modules/location_variant/location_variant.info.yml:4 error: modules/location_variant/location_variant.info.yml: patch does not apply Checking patch modules/location_variant/location_variant.links.action.yml... Checking patch modules/location_variant/location_variant.module... error: while searching for: * Primary module hooks for Location Variant module. */ use Drupal\views\ViewExecutable; use Drupal\Core\Entity\EntityInterface; use Drupal\Core\Form\FormStateInterface; use Drupal\Core\Entity\EntityTypeInterface; error: patch failed: modules/location_variant/location_variant.module:5 error: modules/location_variant/location_variant.module: patch does not apply Checking patch modules/location_variant/src/Controller/LocationController.php... error: while searching for: */ class LocationController extends ControllerBase { private RedirectDestinationInterface $destination; private VariantHandler $variantHandler; private EntityLocationHandler $entityLocationHandler; public function __construct(RedirectDestinationInterface $destination, VariantHandler $variant_handler, EntityLocationHandler $entity_location_handler) { $this->destination = $destination; $this->variantHandler = $variant_handler; $this->entityLocationHandler = $entity_location_handler; } public static function create(ContainerInterface $container) { return new static( $container->get('redirect.destination'), error: patch failed: modules/location_variant/src/Controller/LocationController.php:15 error: modules/location_variant/src/Controller/LocationController.php: patch does not apply Checking patch modules/location_variant/src/EntityLocationHandler.php... error: modules/location_variant/src/EntityLocationHandler.php: No such file or directory Checking patch modules/location_variant/src/EntityTypeInfo.php... error: while searching for: use Drupal\Core\Entity\ContentEntityFormInterface; use Drupal\Core\Field\FieldStorageDefinitionInterface; class EntityTypeInfo { private ImmutableConfig $settings; private EntityLocationHandler $entityLocationHandler; public function __construct(ConfigFactoryInterface $factory, EntityLocationHandler $entity_location_handler) { $this->settings = $factory->get('variants.settings'); $this->entityLocationHandler = $entity_location_handler; error: patch failed: modules/location_variant/src/EntityTypeInfo.php:11 error: modules/location_variant/src/EntityTypeInfo.php: patch does not apply Checking patch modules/location_variant/src/Event/LocationsEvent.php... Checking patch modules/location_variant/src/EventSubscriber/VariationLanguageCodes.php... Checking patch modules/location_variant/src/Form/AddLocation.php... error: while searching for: */ class AddLocation extends FormBase { protected EntityLocationHandler $entityLocationHandler; private LocationHandler $locationHandler; private PrivateTempStore $tempStore; public static function create(ContainerInterface $container) { return new static( $container->get('location_variant.entity_handler'), error: patch failed: modules/location_variant/src/Form/AddLocation.php:15 error: modules/location_variant/src/Form/AddLocation.php: patch does not apply Checking patch modules/location_variant/src/Form/VariationDeleteForm.php... error: while searching for: use Drupal\Core\Entity\ContentEntityDeleteForm; use Drupal\Core\Form\FormStateInterface; use Drupal\Core\Language\LanguageInterface; use function explode; /** error: patch failed: modules/location_variant/src/Form/VariationDeleteForm.php:4 error: modules/location_variant/src/Form/VariationDeleteForm.php: patch does not apply Checking patch modules/location_variant/src/Location.php... Checking patch modules/location_variant/src/LocationHandler.php... error: while searching for: * * @return array * An array of location options. * @throws \Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException * @throws \Drupal\Component\Plugin\Exception\PluginNotFoundException */ error: patch failed: modules/location_variant/src/LocationHandler.php:132 error: modules/location_variant/src/LocationHandler.php: patch does not apply Checking patch modules/location_variant/src/LocationNegotiator.php... error: while searching for: */ class LocationNegotiator implements NegotiatorInterface { private EntityLocationHandler $entityLocationHandler; public function __construct(EntityLocationHandler $entity_location_handler) { $this->entityLocationHandler = $entity_location_handler; } error: patch failed: modules/location_variant/src/LocationNegotiator.php:14 error: modules/location_variant/src/LocationNegotiator.php: patch does not apply Checking patch modules/location_variant/src/Plugin/Derivative/LocationLocalTasks.php... Checking patch modules/location_variant/src/Plugin/Menu/LocalAction/VariantAdd.php... Checking patch modules/location_variant/src/Plugin/views/join/LocationsJoin.php... Checking patch modules/location_variant/src/Plugin/views/relationship/Variant.php... Hunk #1 succeeded at 11 (offset 1 line). error: while searching for: */ class Variant extends RelationshipPluginBase { private LocationHandler $locationHandler; public function __construct(array $configuration, $plugin_id, $plugin_definition, LocationHandler $location_handler) { parent::__construct($configuration, $plugin_id, $plugin_definition); $this->locationHandler = $location_handler; error: patch failed: modules/location_variant/src/Plugin/views/relationship/Variant.php:21 error: modules/location_variant/src/Plugin/views/relationship/Variant.php: patch does not apply Checking patch modules/location_variant/src/Routing/LocationRouteSubscriber.php... Checking patch modules/location_variant/src/ViewsLocationHandler.php... error: while searching for: use Drupal\Core\Config\ConfigFactoryInterface; use Drupal\Core\Entity\EntityTypeManagerInterface; class ViewsLocationHandler { private ImmutableConfig $settings; private LocationHandler $locationHandler; private EntityTypeManagerInterface $entityTypeManager; public function __construct(ConfigFactoryInterface $factory, EntityTypeManagerInterface $entity_type_manager, LocationHandler $location_handler) { $this->locationHandler = $location_handler; $this->settings = $factory->get('variants.settings'); error: patch failed: modules/location_variant/src/ViewsLocationHandler.php:6 error: modules/location_variant/src/ViewsLocationHandler.php: patch does not apply Checking patch src/Entity/Variant.php... error: while searching for: * Gets the entity that this variant applies to. * * @return \Drupal\Core\Entity\EntityInterface * The entity. * * @throws \Drupal\Core\Entity\EntityStorageException */ error: patch failed: src/Entity/Variant.php:78 error: src/Entity/Variant.php: patch does not apply Checking patch src/EntityTypeInfo.php... Checking patch src/Event/LanguagesEvent.php... error: while searching for: */ class LanguagesEvent extends Event { protected array $languages = []; public function __construct(array $languages) { $this->languages = $languages; } public function getLanguages(): array { return $this->languages; } public function addLanguage(Language $language) { $this->languages[$language->getId()] = $language; } error: patch failed: src/Event/LanguagesEvent.php:10 error: src/Event/LanguagesEvent.php: patch does not apply Checking patch src/EventSubscriber/InstallVariantField.php... error: while searching for: $this->entityDefinitionUpdateManager = $entity_definition_update_manager; } public function onConfigSave(ConfigCrudEvent $event) { if ($enabled_entity_types = $this->settings->get('entity_types')) { foreach ($enabled_entity_types as $type) { error: patch failed: src/EventSubscriber/InstallVariantField.php:29 error: src/EventSubscriber/InstallVariantField.php: patch does not apply Checking patch src/Form/VariantsSettingsForm.php... error: while searching for: */ class VariantsSettingsForm extends FormBase { protected EntityTypeManagerInterface $entityTypeManager; protected EntityTypeBundleInfoInterface $entityTypeBundleInfo; public function __construct(EntityTypeManagerInterface $entity_type_manager, EntityTypeBundleInfoInterface $entity_type_bundle_info) { $this->entityTypeManager = $entity_type_manager; $this->entityTypeBundleInfo = $entity_type_bundle_info; } public static function create(ContainerInterface $container) { return new static( $container->get('entity_type.manager'), error: patch failed: src/Form/VariantsSettingsForm.php:14 error: src/Form/VariantsSettingsForm.php: patch does not apply Checking patch src/NegotiationManager.php... Checking patch src/VariantHandler.php... Checking patch src/VariantsLanguageManager.php... error: while searching for: * Variants language manager. */ class VariantsLanguageManager extends LanguageManager { private NegotiationManager $negotiationManager; private EventDispatcherInterface $dispatcher; /** error: patch failed: src/VariantsLanguageManager.php:13 error: src/VariantsLanguageManager.php: patch does not apply Checking patch variants.module... ➜ variants git:(1.0.x)➜ variants git:(1.0.x) curl https://www.drupal.org/files/issues/2022-09-02/variantpatch-3298537-3.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 49618 100 49618 0 0 202k 0 --:--:-- --:--:-- --:--:-- 202k patching file README.md Hunk #1 FAILED at 1. Hunk #2 FAILED at 48. 2 out of 2 hunks FAILED -- saving rejects to file README.md.rej patching file modules/basic_variant/README.md patching file modules/basic_variant/basic_variant.info.yml patching file modules/basic_variant/basic_variant.module patching file modules/basic_variant/src/BasicVariations.php patching file modules/basic_variant/src/EventSubscriber/VariationLanguageCodes.php patching file modules/location_variant/location_variant.info.yml Hunk #1 FAILED at 4. 1 out of 1 hunk FAILED -- saving rejects to file modules/location_variant/location_variant.info.yml.rej patching file modules/location_variant/location_variant.links.action.yml patching file modules/location_variant/location_variant.module Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file modules/location_variant/location_variant.module.rej patching file modules/location_variant/src/Controller/LocationController.php Hunk #1 FAILED at 15. Hunk #2 FAILED at 118. 2 out of 2 hunks FAILED -- saving rejects to file modules/location_variant/src/Controller/LocationController.php.rej can't find file to patch at input line 343 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/modules/location_variant/src/EntityLocationHandler.php b/modules/location_variant/src/EntityLocationHandler.php |index 485202e..b806363 100644 |--- a/modules/location_variant/src/EntityLocationHandler.php |+++ b/modules/location_variant/src/EntityLocationHandler.php -------------------------- File to patch: Skip this patch? [y] Skipping patch. 6 out of 6 hunks ignored patching file modules/location_variant/src/EntityTypeInfo.php Hunk #1 FAILED at 11. Hunk #4 FAILED at 139. 2 out of 4 hunks FAILED -- saving rejects to file modules/location_variant/src/EntityTypeInfo.php.rej patching file modules/location_variant/src/Event/LocationsEvent.php patching file modules/location_variant/src/EventSubscriber/VariationLanguageCodes.php patching file modules/location_variant/src/Form/AddLocation.php Hunk #1 FAILED at 15. Hunk #2 FAILED at 50. 2 out of 2 hunks FAILED -- saving rejects to file modules/location_variant/src/Form/AddLocation.php.rej patching file modules/location_variant/src/Form/VariationDeleteForm.php Hunk #1 FAILED at 4. Hunk #2 FAILED at 59. 2 out of 2 hunks FAILED -- saving rejects to file modules/location_variant/src/Form/VariationDeleteForm.php.rej patching file modules/location_variant/src/Location.php patching file modules/location_variant/src/LocationHandler.php Hunk #2 FAILED at 161. Hunk #3 FAILED at 173. 2 out of 3 hunks FAILED -- saving rejects to file modules/location_variant/src/LocationHandler.php.rej patching file modules/location_variant/src/LocationNegotiator.php Hunk #1 FAILED at 14. Hunk #2 FAILED at 116. 2 out of 2 hunks FAILED -- saving rejects to file modules/location_variant/src/LocationNegotiator.php.rej patching file modules/location_variant/src/Plugin/Derivative/LocationLocalTasks.php patching file modules/location_variant/src/Plugin/Menu/LocalAction/VariantAdd.php patching file modules/location_variant/src/Plugin/views/join/LocationsJoin.php patching file modules/location_variant/src/Plugin/views/relationship/Variant.php Hunk #1 succeeded at 11 (offset 1 line). Hunk #2 FAILED at 22. Hunk #3 FAILED at 87. 2 out of 3 hunks FAILED -- saving rejects to file modules/location_variant/src/Plugin/views/relationship/Variant.php.rej patching file modules/location_variant/src/Routing/LocationRouteSubscriber.php patching file modules/location_variant/src/ViewsLocationHandler.php Hunk #1 FAILED at 6. Hunk #2 succeeded at 55 with fuzz 2. 1 out of 2 hunks FAILED -- saving rejects to file modules/location_variant/src/ViewsLocationHandler.php.rej patching file src/Entity/Variant.php Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 3 out of 3 hunks ignored -- saving rejects to file src/Entity/Variant.php.rej patching file src/EntityTypeInfo.php patching file src/Event/LanguagesEvent.php Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- saving rejects to file src/Event/LanguagesEvent.php.rej patching file src/EventSubscriber/InstallVariantField.php Hunk #2 succeeded at 55 with fuzz 2. Hunk #3 FAILED at 65. 1 out of 3 hunks FAILED -- saving rejects to file src/EventSubscriber/InstallVariantField.php.rej patching file src/Form/VariantsSettingsForm.php Hunk #1 FAILED at 14. 1 out of 1 hunk FAILED -- saving rejects to file src/Form/VariantsSettingsForm.php.rej patching file src/NegotiationManager.php patching file src/VariantHandler.php patching file src/VariantsLanguageManager.php Hunk #1 FAILED at 13. Hunk #2 FAILED at 41. 2 out of 2 hunks FAILED -- saving rejects to file src/VariantsLanguageManager.php.rej patching file variants.module ➜ variants git:(1.0.x) ✗ .. ➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml variants FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/variants.routing.yml ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 15 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather than "access administration pages" which is about | | viewing but not changing configurations. ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/README.md --------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES --------------------------------------------------------------------------------------- 2 | WARNING | Line exceeds 80 characters; contains 223 characters 6 | WARNING | Line exceeds 80 characters; contains 218 characters 9 | WARNING | Line exceeds 80 characters; contains 174 characters 38 | WARNING | Line exceeds 80 characters; contains 379 characters 39 | WARNING | Line exceeds 80 characters; contains 339 characters 42 | WARNING | Line exceeds 80 characters; contains 182 characters --------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/basic_variant/src/BasicNegotiator.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Render\BubbleableMetadata. 21 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 44 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/basic_variant/src/EventSubscriber/VariationLanguageCodes.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection. -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/basic_variant/src/BasicVariations.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Random. 82 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/location_variant.module --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeInterface. --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/location_variant_entity_workflow/src/Routing/RouteSubscriber.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RoutingEvents. ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/variants_locale/variants_locale.module ----------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 3 | WARNING | [ ] Global constants should not be used, move it to a class or interface 24 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 37 | ERROR | [x] Expected newline after closing brace ----------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/variants_locale/src/Form/JsTranslationsForm.php -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 8 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 6 | WARNING | [x] Unused use statement 19 | ERROR | [ ] Missing short description in doc comment 24 | ERROR | [x] Missing function doc comment 61 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 76 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 81 | ERROR | [x] Missing function doc comment 89 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/variants_locale/src/JsTranslations.php ----------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 9 ERRORS AFFECTING 9 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityRepositoryInterface. 13 | ERROR | [x] Missing class doc comment 15 | ERROR | [ ] Missing member variable doc comment 16 | ERROR | [ ] Missing member variable doc comment 17 | ERROR | [ ] Missing member variable doc comment 18 | ERROR | [ ] Missing member variable doc comment 19 | ERROR | [ ] Missing member variable doc comment 29 | ERROR | [x] Missing function doc comment 41 | ERROR | [x] Missing function doc comment ----------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/variants_locale/src/Commands/VariantsLocaleCommands.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Missing class doc comment 10 | ERROR | [ ] Missing short description in doc comment 17 | ERROR | [x] Expected 1 blank line after function; 2 found 21 | ERROR | [x] Doc comment short description must end with a full stop ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/config_location_variant/config_location_variant.info.yml ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/config_location_variant/src/Config/ConfigLocationVariantFactoryOverride.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 10 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheableMetadata. 32 | ERROR | [ ] Missing member variable doc comment 33 | ERROR | [ ] Missing member variable doc comment 34 | ERROR | [ ] Missing member variable doc comment 35 | ERROR | [ ] Missing member variable doc comment 89 | ERROR | [x] Expected 1 blank line after function; 2 found 119 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 135 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 152 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 169 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/config_location_variant/src/Config/ConfigLocationOverride.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\StorableConfigBase. 18 | ERROR | [ ] Missing member variable doc comment ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/config_location_variant/src/EventSubscriber/ConfigLanguageCodes.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection. 18 | ERROR | [ ] Missing member variable doc comment 19 | ERROR | [ ] Missing member variable doc comment 20 | ERROR | [ ] Missing member variable doc comment 42 | WARNING | [ ] Unused variable $location_id. ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/config_location_variant/src/EventSubscriber/LanguageRequestSubscriber.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Language\LanguageManagerInterface. 18 | ERROR | [ ] Missing member variable doc comment 19 | ERROR | [ ] Missing member variable doc comment 63 | ERROR | [ ] The array declaration extends to column 129 (the limit is 120). The array content should be split up over multiple lines ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/css/string-translation-mode.css ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 3 | ERROR | Style definitions must end with a semicolon ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/string_location_variant.install ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 57 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/string_location_variant.info.yml ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/string_location_variant.module --------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment --------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Form/StringSettingsForm.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 6 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 14 | ERROR | [x] Missing function doc comment 24 | ERROR | [x] Expected 1 blank line after function; 2 found 59 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 59 | WARNING | [ ] Unused variable $id. 107 | ERROR | [x] Expected 1 space before opening brace; found 0 133 | ERROR | [x] Expected newline after closing brace 162 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Form/StringForm.php -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityForm. -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Form/EnableStringTranslationModeForm.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormBase. 35 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 44 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Form/TranslateStringForm.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormBase. 35 | WARNING | [ ] Unused variable $arguments. 97 | ERROR | [x] Expected 1 blank line after function; 2 found 109 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 135 | ERROR | [x] Array indentation error, expected 8 spaces but found 10 136 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 8 ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/StringListBuilder.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface. 101 | ERROR | [x] Expected 1 blank line after function; 2 found ---------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Entity/Strings.php ------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\BaseFieldDefinition. 82 | ERROR | [x] Expected 1 blank line before function; 2 found 95 | ERROR | [x] Missing function doc comment ------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/StringsTranslator.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\DependencySerializationTrait. 10 | ERROR | [x] Missing class doc comment 27 | ERROR | [x] Expected 1 blank line before function; 2 found 40 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 41 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Plugin/Validation/Constraint/SourceConstraint.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 18 | ERROR | [x] You must use "/**" style comments for a member variable comment -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Plugin/Validation/Constraint/SourceConstraintValidator.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 9 ERRORS AND 1 WARNING AFFECTING 10 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. 11 | ERROR | [x] Missing class doc comment 13 | ERROR | [ ] Missing member variable doc comment 19 | ERROR | [x] Missing function doc comment 23 | ERROR | [x] Missing function doc comment 24 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 26 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 37 | ERROR | [x] Array closing indentation error, expected 10 spaces but found 12 41 | ERROR | [x] Expected 1 blank line after function; 2 found 44 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Controller/DisableStringTranslationModeController.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\RedirectResponse. 9 | ERROR | [x] Missing class doc comment ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/StringAccessControlHandler.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityAccessControlHandler. ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/StringTranslationManager.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 9 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\bootstrap\Utility\Crypt. 20 | ERROR | [ ] Class constants must be uppercase; expected STATICCACHE but found StaticCache 22 | ERROR | [ ] Missing member variable doc comment 52 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters 56 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 109 | WARNING | [x] A comma should follow the last multiline array item. Found: $arguments 124 | ERROR | [ ] Description for the @return value is missing 137 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found 165 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/StringInterface.php -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityInterface. -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/EventSubscriber/StringCollectionSubscriber.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpKernel\Event\ResponseEvent. 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 15 | ERROR | [x] Missing class doc comment ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/EventSubscriber/TwigRenderTemplateSubscriber.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\string_location_variant\StringTranslationManager. 14 | ERROR | [x] Missing function doc comment 24 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 26 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/EventSubscriber/StringsUiIgnoredElements.php --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 18 | ERROR | Missing parameter comment 20 | ERROR | Description for the @return value is missing --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/Event/StringsUiIgnoreElementsEvent.php --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Missing class doc comment 9 | ERROR | [ ] Missing member variable doc comment 11 | ERROR | [ ] Missing short description in doc comment 12 | ERROR | [ ] Description for the @return value is missing 18 | ERROR | [ ] Missing short description in doc comment 19 | ERROR | [ ] Missing parameter comment --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/modules/string_location_variant/src/StringsRepository.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 28 ERRORS AND 2 WARNINGS AFFECTING 27 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection. 24 | ERROR | [ ] Missing member variable doc comment 25 | ERROR | [ ] Missing member variable doc comment 26 | ERROR | [ ] Missing member variable doc comment 27 | ERROR | [ ] Missing member variable doc comment 28 | ERROR | [ ] Missing member variable doc comment 29 | ERROR | [ ] Missing member variable doc comment 30 | ERROR | [ ] Missing member variable doc comment 31 | ERROR | [ ] Missing member variable doc comment 55 | ERROR | [x] Separate the @return and @throws sections by a blank line. 67 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 88 | ERROR | [x] Expected newline after closing brace 109 | ERROR | [ ] Missing parameter type 115 | ERROR | [x] Separate the @return and @throws sections by a blank line. 122 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 129 | ERROR | [x] Expected 1 space after "="; 2 found 131 | ERROR | [x] Expected newline after closing brace 144 | ERROR | [x] Separate the @param and @see sections by a blank line. 144 | ERROR | [x] Trailing punctuation for @see references is not allowed. 148 | ERROR | [x] Separate the @return and @throws sections by a blank line. 152 | ERROR | [x] Expected 1 space before "=>"; 0 found 166 | ERROR | [x] Separate the @param and @see sections by a blank line. 166 | ERROR | [x] Trailing punctuation for @see references is not allowed. 172 | ERROR | [x] Separate the @return and @throws sections by a blank line. 196 | ERROR | [x] Separate the @param and @see sections by a blank line. 196 | ERROR | [x] Trailing punctuation for @see references is not allowed. 199 | ERROR | [x] Expected "\Drupal\variants\Entity\Variant|null" but found "\Drupal\variants\Entity\Variant|NULL" for parameter type 202 | ERROR | [ ] Description for the @return value is missing 215 | ERROR | [ ] Missing parameter type 220 | ERROR | [x] Separate the @return and @throws sections by a blank line. ---------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/location_variant.install ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 13 | ERROR | [x] Expected 1 blank line after function; 2 found ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Form/VariationDeleteForm.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityDeleteForm. 104 | ERROR | [ ] The array declaration extends to column 142 (the limit is 120). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Form/VariantSettingsFormAlter.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AND 3 WARNINGS AFFECTING 15 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 18 | ERROR | [x] Missing class doc comment 23 | ERROR | [ ] Missing member variable doc comment 24 | ERROR | [ ] Missing member variable doc comment 25 | ERROR | [ ] Missing member variable doc comment 26 | ERROR | [ ] Missing member variable doc comment 29 | ERROR | [x] Expected 1 blank line before function; 2 found 36 | ERROR | [x] Missing function doc comment 48 | ERROR | [ ] Missing parameter type 72 | ERROR | [x] Concat operator must be surrounded by a single space 114 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 131 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 132 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 174 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 203 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Form/AddLocation.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormBase. 21 | ERROR | [ ] Missing member variable doc comment 22 | ERROR | [ ] Missing member variable doc comment 23 | ERROR | [ ] Missing member variable doc comment 24 | ERROR | [ ] Missing member variable doc comment 26 | ERROR | [x] Missing function doc comment 80 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 82 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/LocationNegotiator.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 5 WARNINGS AFFECTING 7 LINES --------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. 17 | ERROR | [ ] Missing member variable doc comment 30 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 43 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 52 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 74 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 83 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Plugin/Derivative/LocationLocalTasks.php --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Plugin/views/relationship/Variant.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Language\LanguageManagerInterface. 25 | ERROR | [ ] Missing member variable doc comment 26 | ERROR | [ ] Missing member variable doc comment 111 | ERROR | [x] Concat operator must be surrounded by a single space 118 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 134 | ERROR | [x] Missing function doc comment ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Controller/LocationController.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Controller\ControllerBase. 18 | ERROR | [ ] Missing member variable doc comment 19 | ERROR | [ ] Missing member variable doc comment 20 | ERROR | [ ] Missing member variable doc comment 28 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Controller/DynamicallyCreateVariation.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Controller\ControllerBase. 21 | ERROR | [ ] Missing member variable doc comment 22 | ERROR | [ ] Missing member variable doc comment 23 | ERROR | [ ] Missing member variable doc comment ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/ViewsLocationHandler.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES ----------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ImmutableConfig. 9 | WARNING | [x] Unused use statement 11 | ERROR | [x] Missing class doc comment 13 | ERROR | [ ] Missing member variable doc comment 14 | ERROR | [ ] Missing member variable doc comment 17 | ERROR | [x] Expected 1 blank line before function; 2 found ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/LocationVariantAliasRepositoryTrait.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 26 | WARNING | [x] A comma should follow the last multiline array item. Found: LANGCODE_NOT_SPECIFIED -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Routing/LocationRouteSubscriber.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ImmutableConfig. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/EntityTypeInfo.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 8 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ImmutableConfig. 14 | ERROR | [x] Missing class doc comment 16 | ERROR | [ ] Missing member variable doc comment 17 | ERROR | [ ] Missing member variable doc comment 74 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 76 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters 77 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 139 | ERROR | [ ] The array declaration extends to column 173 (the limit is 120). The array content should be split up over multiple lines ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/EventSubscriber/VariationLanguageCodes.php ----------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection. ----------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/EntityVariationHandler.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 11 ERRORS AND 38 WARNINGS AFFECTING 49 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link. 27 | ERROR | [ ] Missing member variable doc comment 28 | ERROR | [ ] Missing member variable doc comment 29 | ERROR | [ ] Missing member variable doc comment 30 | ERROR | [ ] Missing member variable doc comment 31 | ERROR | [ ] Missing member variable doc comment 32 | ERROR | [ ] Missing member variable doc comment 33 | ERROR | [ ] Missing member variable doc comment 87 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters 88 | WARNING | [ ] Line exceeds 80 characters; contains 119 characters 96 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 97 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters 98 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters 101 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters 118 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters 169 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters 170 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters 211 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 212 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 230 | WARNING | [ ] Line exceeds 80 characters; contains 119 characters 238 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 239 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 266 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 268 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 290 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 318 | ERROR | [ ] Parameter $save is not described in comment 392 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters 408 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 409 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 410 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 469 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 478 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 486 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 496 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 510 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 514 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 519 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 532 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 533 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 554 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 574 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 631 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 635 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 639 | ERROR | [ ] The array declaration extends to column 159 (the limit is 120). The array content should be split up over multiple lines 665 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 673 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters 674 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters 675 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters 721 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Event/LocationsEvent.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/Event/CanEditDefaultEvent.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 19 ERRORS AFFECTING 17 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. 8 | ERROR | [x] Missing class doc comment 10 | ERROR | [ ] Missing member variable doc comment 12 | ERROR | [ ] Missing member variable doc comment 13 | ERROR | [ ] Class property $form_id should use lowerCamel naming without underscores 13 | ERROR | [ ] Missing member variable doc comment 20 | ERROR | [ ] Missing short description in doc comment 21 | ERROR | [ ] Description for the @return value is missing 27 | ERROR | [ ] Missing short description in doc comment 28 | ERROR | [ ] Missing parameter comment 28 | ERROR | [ ] Doc comment for parameter $canEdit does not match actual variable name <undefined> 34 | ERROR | [ ] Missing short description in doc comment 35 | ERROR | [ ] Description for the @return value is missing 41 | ERROR | [ ] Missing short description in doc comment 42 | ERROR | [ ] Missing parameter comment 48 | ERROR | [ ] Missing short description in doc comment 49 | ERROR | [ ] Description for the @return value is missing 55 | ERROR | [ ] Missing short description in doc comment 56 | ERROR | [ ] Missing parameter comment ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/modules/location_variant/src/LocationHandler.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/NegotiationManager.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Language\LanguageInterface. 130 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/VariantTypeListBuilder.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/VariantHandler.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/Entity/Variant.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/EntityTypeInfo.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeInterface. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/VariantsLanguageManager.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Language\LanguageDefault. 20 | ERROR | [ ] Missing member variable doc comment 21 | ERROR | [ ] Missing member variable doc comment ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/EventSubscriber/InstallVariantField.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ImmutableConfig. 93 | ERROR | [x] Missing function doc comment 98 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 107 | ERROR | [x] Missing function doc comment 112 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 121 | ERROR | [x] Expected 1 blank line after function; 0 found 122 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/VariantsServiceProvider.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/variants/src/Event/LanguagesEvent.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES --------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event. 13 | ERROR | [ ] Missing member variable doc comment 19 | ERROR | [x] Missing function doc comment 23 | ERROR | [x] Missing function doc comment 27 | ERROR | [x] Missing function doc comment --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- Time: 1.88 secs; Memory: 16MB ➜ contribI still encountered more than the issues mentioned in comment #3.
Thank you.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Let's use the created merge request, now that patches are no longer tested.