The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 5:48am 12 February 2023 - 🇦🇲Armenia Murz Yerevan, Armenia
I've rebased my MR to 10.1.x and also have added a unit test for the new feature, please review.
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 3:25pm 28 February 2023 - 🇺🇸United States smustgrave
Verified test fails without fix
Symfony\Component\Validator\Exception\InvalidOptionsException : The options "propertyName" do not exist in constraint "Drupal\Core\Validation\Plugin\Validation\Constraint\UniqueFieldConstraint".
Issue summary lines up with fix and don't see issue it could cause.
MAY need a change record but will let the committer decide.
- Status changed to Needs work
over 1 year ago 5:06am 22 March 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Assigned to arunkumark
- @arunkumark opened merge request.
- Issue was unassigned.
- @arunkumark opened merge request.
- Status changed to Needs review
over 1 year ago 7:05am 22 March 2023 - Status changed to Needs work
over 1 year ago 7:47am 22 March 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
about 1 year ago 28,511 pass, 1 fail - last update
about 1 year ago 28,511 pass, 1 fail - last update
about 1 year ago 28,519 pass - Status changed to Needs review
about 1 year ago 2:32pm 13 May 2023 - 🇺🇸United States smustgrave
Wonder if this is solved in 📌 UniqueFieldValueValidator works only with single value fields Fixed ?
- 🇦🇲Armenia Murz Yerevan, Armenia
No, the 📌 UniqueFieldValueValidator works only with single value fields Fixed is related to multiple value fields, but this one - is for fields with fields, that use non-standard property name (eg "data" instead of "value") or several properties.
- 🇺🇸United States smustgrave
Ah briefly taking a look thought that ticket was loading the property different from now
- 🇦🇲Armenia Murz Yerevan, Armenia
Yes, but that one is not yet merged, after merging I can adapt that changes to my MR.
- Status changed to Needs work
about 1 year ago 9:52am 8 June 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The MR in 2478663 should address this, although additional tests for Link fields and fields with fully custom properties would be nice in order to check for regressions.
Checking the MR -- although 📌 UniqueFieldValueValidator works only with single value fields Fixed should now allow for constraints on any field according to their main property, it looks like this issue is intended to allow for constraints on properties that are not the "main property."
The MR should be updated according to the changes made and committed in the other ticket, in particular by ensuring the test cases check on properties that aren't the field's main property, e.g. a link field's Title property.