- π―π΄Jordan Rajab Natshah Jordan
Hoping for a soft commit and a soft tag release (
pre-release
), to speed up update testing with Drupal 10 - πΊπΈUnited States pcate
+1 RTBC. The patch applied cleanly and fixed D10 compatibility issues.
- πΊπΈUnited States jeremy.sloan
PCate what branch were you on when you got the patch to apply? I am using 2.0@alpha and the patch will not apply.
- πΊπΈUnited States jeremy.sloan
PCate which fast_404 version are you using? I am using 2.0.0-alpha6 and the patch doesn't apply.
- πΊπΈUnited States pcate
PCate which fast_404 version are you using? I am using 2.0.0-alpha6 and the patch doesn't apply.
I applied it the 8.x-2.x branch.
- First commit to issue fork.
- @yahyaalhamad opened merge request.
- π―π΄Jordan yahyaalhamad Palestine
I created an issue fork using the patch, to use it:
Use this in your composer.json:
{ "type": "composer", "url": "https://packages.drupal.org/8", "exclude": [ "drupal/fast_404" ] }, { "type": "git", "url": "https://git.drupalcode.org/issue/fast_404-3287465.git" }
Install fast_404 from the issue fork.
composer require 'drupal/fast_404:dev-3287465-automated-drupal-10'
- π«π·France Fabsgugu
This MR can be accepted?
It would be nice to release a new version with this commit. - πΊπΈUnited States edmund.dunn Olympia, WA
Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue.
- πΊπΈUnited States edmund.dunn Olympia, WA
Never mind, it doesn't apply using composer. My apologies.
- πΊπΈUnited States edmund.dunn Olympia, WA
This applies cleanly via composer. I had to take out the portion that applied to fast_404.info.yml. If anyone can get that working via composer it would be super helpful!
- πΊπΈUnited States edmund.dunn Olympia, WA
Found the solution. https://www.drupal.org/project/drupal/issues/3036459#comment-14836380 π Packaging info from .info.yml often creates conflicts when patching Active I had to add it in a separate patch file. But it installs cleanly.
-
joseph.olstad β
committed 435102af on 8.x-2.x
Issue #3287465 by YahyaAlHamad, Project Update Bot, edmund.dunn, ershov....
-
joseph.olstad β
committed 435102af on 8.x-2.x
- Status changed to Fixed
over 1 year ago 5:51pm 30 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.