Drupal 10 compatibility

Thank you, for having time to maintain the Entity Embed important module.

Hoping for a soft tag release ( pre-release ), to ease testing with Drupal 10
Testing now with the 1.x-dev development.

Worked great for me with the patch from MR9. Looking forward to a release.

Agrees with Adam

Note that we probably should NOT tag a release with this change until we have 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC done, because without CKEditor 5 support, this module is essentially worthless with Drupal 10 core alone.

@Maintainers: If 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC won't land soon and nobody can do anything about it, would it perhaps make sense to document on the module page, why there's no Drupal 10 compatible release yet for this module?

Or can anyone push things forward at 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC or become Co-Maintainer of Embed? Or does someone know someone who knows the maintainers to ping them? ;)

Thanks!

@Maintaners: Do you have any idea if your team plans to be releasing a D10 compatible version of this module in the near future? Any help you can provide would be appreciated!

Thanks

You can still use ckeditor 4 w/ drupal 10. So a dev release that only supports ckeditor 4 isn't entirely worthless.

@phenaproxima, CKE4 is still relevant for D10 as updating CKE4 to CKE5 is not that straightforward. So, having a D10 compliant release with CKE4 support only is completely fine

I'm using Drupal 9.5.x and this is the only important module still showing not compatible on Upgrade Status. I tried following this thread but lost it. Is there a available patch that would cover the upgrade to 10?

@wxman I think you're looking for https://www.drupal.org/project/entity_embed/issues/3272732 ✨ Drupal 10 & CKEditor 5 readiness Fixed which has a patch that needs review.

@SamLerner I think it looks like the working patch is https://www.drupal.org/files/issues/2023-05-05/entity_embed-3272732-80.p... → .
What I'm wondering, before I try it, if this is one I can apply to the module while still using D9.5.x. As far as I understand, the upgrade won't work unless all the installed modules show ready for D10.

@wxman you'd need a patched and working version of Embed to also get a patched version of Entity Embed working. Hopefully that gets resolved soon, lots of attention on it since it's DrupalCon. Once Embed is CKE5-compatible, this should quickly follow.