- 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi,
According to @lostcarpark's suggestion, I have removed the rounded corners.
Please review.
Thanks
- 🇮🇪Ireland lostcarpark
Updated logo in issue to #9.
Verified image is a .png file, image dimensions are 512x512 pixels, and file size is under 10K.
+1 from me for #9 to go RTBC.
- 🇺🇸United States chrisfromredfin Portland, Maine
I worry about the white band in context. Do you think we should put a border around it or make the dividing line a different color?
- 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi @chrisfromredfin, according to #12, I have added a slight border around the white band in context.
Now you have an option to compare with logo provided in #9. Also I reduced the size a bit more.
Please have a look.
Thanks
- 🇮🇪Ireland lostcarpark
Personally, I like the version in #9. I like the way it "breaks the fourth wall" by having the background run through it.
I don't think the very thin border added in #14 will be visible at all when it's reduced to the icon size. If a change is needed, it should be a very clear change, not a token change.
I've mocked 3 possible solutions on the image below:
On the left, I've added thin (but visible) borders.
In the middle, I've changed the background of the break (to match the colours of the <>).
On the right I've added a thicker border.
If we were going to add a border, I think the thick one looks better, though it does make the break look a bit like an input box.
I think I prefer the background colour to the line, however.
I'd still vote for the original #9 if it was an election, but thought it worth seeing how options look visually.
- 🇮🇪Ireland lostcarpark
By the way, well done on getting the file size down to 2.21KB while keeping it looking crisp!
- 🇺🇸United States butterwise
FWIW, my preference is the third option (far right) in #15. Consider making the brackets (<>) white for simplicity's sake?
- Status changed to RTBC
over 1 year ago 5:56pm 7 June 2023 - 🇺🇸United States catsbap
I have reviewed this and it meets the requirements.
- Status changed to Needs work
over 1 year ago 6:56pm 7 June 2023 - 🇮🇪Ireland lostcarpark
Sorry, @catsbap, could you clarify what you reviewed.
There are several suggestions for discussion, which probably needs @urvashi_vora to post an adjusted version. I don't think this is ready for RTBC yet.
Thoughts?
- Status changed to Needs review
over 1 year ago 7:41pm 7 June 2023 - 🇺🇸United States anilu@ Houston, TX
Reviewing this issue on mentor contribution room #DrupalconPittsburgh 2023
We like the proposal on https://www.drupal.org/project/project_browser/issues/3283041#comment-15... 📌 Embed Project - Update Logo RTBC
The simplest the better!
Borders will add unnecessary complexity.
- Status changed to RTBC
over 1 year ago 7:45pm 7 June 2023 - 🇺🇸United States JorgeOspina
leslieg → credited JorgeOspina → .
- Status changed to Fixed
3 months ago 1:47am 13 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.