- 🇺🇸United States smustgrave
Thanks for bringing this back up. Some of these were my first core contribution attempts so glad to be able to circle back
- 🇳🇿New Zealand quietone
Moved two tests that are testing the Standard profile to the list of the one not to be converted.
- 🇺🇸United States smustgrave
@quietone can help on these but want to get one reviewed before moving on to the next. Been having trouble with that part.
- 🇺🇸United States smustgrave
With regards to MediaStandardProfileTest it appears to only be testing the media bundles that ship with standard. We could move those config to a test module thoughts?
- 🇳🇿New Zealand quietone
The remaining test is core/modules/media/tests/src/FunctionalJavascript/MediaStandardProfileTest.php. I asked in Slack #media if this needs to use the standard profile. marcoscano, a maintainer, replied that it does, stating "In principle that's testing the config that ships with the standard profile, so I'd say yes, I think so". It is good I asked because when I first looked at the file I didn't think it needed to use the standard profile.
I did some digging and found the comment → where the test was added. In that comment seanB states,
Added MediaStandardProfileTest to test the standard profile form configuration, creation, field mapping and display configuration. We could expand on that in the future. See if we can move/remove the media specific code in Drupal\Tests\standard\Functional\StandardTest and see what we want to do with Drupal\Tests\media\FunctionalJavascript\MediaDisplayTest since there is some overlap.
I spent a few minutes comparing the two tests and I found that MediaDisplayTest is testing the standard profile configuration. So, this needs a followup up issue to remove that overlap.
- Status changed to Fixed
over 1 year ago 10:24pm 10 January 2024 - 🇳🇿New Zealand quietone
Made a follow up to look at the overlap mentioned in #25, 📌 Remove overlap in StandardTest and MediaDisplayTest Active .
All the children are done and the followup is made. I am setting this to Fixed
Thanks to everyone who worked in the child issues to speed up the tests.
Woohoo!
- 🇳🇿New Zealand quietone
The follow up was made, see previous comment
Automatically closed - issue fixed for 2 weeks with no activity.